tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
// Diagnostic system
|
|
|
|
|
//
|
2022-05-03 14:14:29 -04:00
|
|
|
|
// Copyright (C) 2014-2022 Ryan Specialty Group, LLC.
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
//
|
|
|
|
|
// This file is part of TAME.
|
|
|
|
|
//
|
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
|
|
|
// it under the terms of the GNU General Public License as published by
|
|
|
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
|
|
|
// (at your option) any later version.
|
|
|
|
|
//
|
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
|
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
// GNU General Public License for more details.
|
|
|
|
|
//
|
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
|
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
|
|
|
|
|
//! Diagnostic system for error reporting.
|
|
|
|
|
//!
|
|
|
|
|
//! This system is heavily motivated by Rust's.
|
|
|
|
|
//! While the data structures and organization may differ,
|
|
|
|
|
//! the diagnostic output is visually similar.
|
2022-05-02 09:44:53 -04:00
|
|
|
|
//!
|
|
|
|
|
//! Visual Report
|
|
|
|
|
//! -------------
|
|
|
|
|
//! The primary output of the system is a [`Report`](report::Report).
|
|
|
|
|
//! A report consists not only of the diagnostic information provided by the
|
|
|
|
|
//! system
|
|
|
|
|
//! (such as error messages),
|
|
|
|
|
//! but also annotated source code.
|
|
|
|
|
//! Reports attempt to create a narrative that walks the user through why
|
|
|
|
|
//! and how problems arose,
|
|
|
|
|
//! and hopefully provides information on how to resolve the problem.
|
|
|
|
|
//!
|
|
|
|
|
//! Here is an example report:
|
|
|
|
|
//!
|
|
|
|
|
//! ```text
|
|
|
|
|
//! error: expected closing tag for `classify`
|
|
|
|
|
//! --> /home/user/program/foo.xml:16:5
|
|
|
|
|
//! |
|
|
|
|
|
//! 16 | <classify as="foo" desc="Example classification">
|
|
|
|
|
//! | --------- note: element `classify` is opened here
|
|
|
|
|
//!
|
|
|
|
|
//! --> /home/user/program/foo.xml:24:5
|
|
|
|
|
//! |
|
|
|
|
|
//! 24 | </wrong>
|
|
|
|
|
//! | ^^^^^^^^ error: expected `</classify>`
|
|
|
|
|
//! ```
|
|
|
|
|
//!
|
|
|
|
|
//! A single report is produced for each error
|
|
|
|
|
//! (or other suitable diagnostic event).
|
|
|
|
|
//! The system may produce multiple reports at a time if it discovers
|
|
|
|
|
//! multiple issues and is able to recover enough to continue to discover
|
|
|
|
|
//! others.
|
|
|
|
|
//!
|
|
|
|
|
//! Each report is separated into a number of sections,
|
|
|
|
|
//! with each section delimited by a header.
|
|
|
|
|
//! Each section describes one or more spans related to a range of related
|
|
|
|
|
//! source lines.
|
|
|
|
|
//! Those source lines are annotated using the [`Span`]s associated with the
|
|
|
|
|
//! emitted diagnostic data,
|
|
|
|
|
//! such as an error.
|
|
|
|
|
//!
|
|
|
|
|
//! Each section has a _gutter_ containing the line number of source lines.
|
|
|
|
|
//! The area below the section header and to the right of the gutter is
|
|
|
|
|
//! called the _body_ of the section.
|
|
|
|
|
//! The gutter will expand as needed to fit the line number.
|
|
|
|
|
//!
|
|
|
|
|
//! _Warning: Reports do not yet strip terminal escape sequences,
|
|
|
|
|
//! which may interfere with the diagnostic output.
|
|
|
|
|
//! This may represent a security risk depending on your threat model,
|
|
|
|
|
//! but does require access to the source code being compiled._
|
|
|
|
|
//!
|
|
|
|
|
//! See the [`report`] module for more information.
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
|
tamer: diagnose::panic: New module
This change introduces diagnostic messages for panics. The intent is to be
able to use panics in situations where it is either not possible to or not
worth the time to recover from errors and ensure a consistent/sensible
system state. In those situations, we still ought to be able to provide the
user with useful information to attempt to get unstuck, since the error is
surely in response to some particular input, and maybe that input can be
tweaked to work around the problem.
Ideally, invalid states are avoided using the type system and statically
verified at compile-time. But this is not always possible, or in some cases
may be way more effort or cause way more code complexity than is worth,
given the unliklihood of the error occurring.
With that said, it's been interesting, over the past >10y that TAME has
existed, seeing how unlikely errors do sometimes pop up many years after
they were written. It's also interesting to have my intuition of what is
"unlikely" challenged, but hopefully it holds generally.
DEV-7145
2022-08-09 15:08:32 -04:00
|
|
|
|
#[macro_use]
|
|
|
|
|
pub mod panic;
|
|
|
|
|
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
mod report;
|
2022-05-02 09:49:22 -04:00
|
|
|
|
mod resolve;
|
2022-04-14 15:52:08 -04:00
|
|
|
|
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
pub use report::{Reporter, VisualReporter};
|
2022-05-02 09:49:22 -04:00
|
|
|
|
pub use resolve::FsSpanResolver;
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
|
|
|
|
|
use core::fmt;
|
2022-07-21 00:27:33 -04:00
|
|
|
|
use std::{borrow::Cow, convert::Infallible, error::Error, fmt::Display};
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
|
|
|
|
|
use crate::span::Span;
|
|
|
|
|
|
|
|
|
|
/// Diagnostic report.
|
|
|
|
|
///
|
|
|
|
|
/// This describes an error condition or other special event using a series
|
|
|
|
|
/// of [`Span`]s to describe the source, cause, and circumstances around
|
|
|
|
|
/// an event.
|
|
|
|
|
pub trait Diagnostic: Error + Sized {
|
|
|
|
|
/// Produce a series of [`AnnotatedSpan`]s describing the source and
|
|
|
|
|
/// circumstances of the diagnostic event.
|
|
|
|
|
fn describe(&self) -> Vec<AnnotatedSpan>;
|
|
|
|
|
}
|
|
|
|
|
|
2022-07-21 00:27:33 -04:00
|
|
|
|
impl Diagnostic for Infallible {
|
|
|
|
|
fn describe(&self) -> Vec<AnnotatedSpan> {
|
|
|
|
|
// This should never actually happen unless someone is explicitly
|
|
|
|
|
// invoking this method on `Infallible`.
|
|
|
|
|
unreachable!("Infallible is not supposed to fail")
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
/// Diagnostic severity level.
|
|
|
|
|
///
|
|
|
|
|
/// Levels are used both for entire reports and for styling of individual
|
|
|
|
|
/// [`AnnotatedSpan`]s.
|
2022-04-27 10:45:31 -04:00
|
|
|
|
///
|
2022-10-21 15:35:27 -04:00
|
|
|
|
/// Higher severity levels are represented by lower integer values
|
|
|
|
|
/// (e.g. level 1 is the worst),
|
|
|
|
|
/// like DEFCON levels.
|
|
|
|
|
/// The rationale here is that,
|
|
|
|
|
/// provided that you remember that these are 1-indexed,
|
|
|
|
|
/// you do not need to know how many levels exist to know how severe it
|
|
|
|
|
/// is.
|
2022-04-27 10:45:31 -04:00
|
|
|
|
#[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Clone, Copy, Default)]
|
|
|
|
|
#[repr(u8)]
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
pub enum Level {
|
|
|
|
|
/// An error internal to TAMER that the user cannot resolve,
|
|
|
|
|
/// but may be able to work around.
|
2022-04-27 10:45:31 -04:00
|
|
|
|
InternalError = 1,
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
|
|
|
|
|
/// A user-resolvable error.
|
|
|
|
|
///
|
|
|
|
|
/// These represent errors resulting from the user's input.
|
|
|
|
|
Error,
|
|
|
|
|
|
|
|
|
|
/// Useful information that supplements other messages.
|
|
|
|
|
///
|
|
|
|
|
/// This is most often used when multiple spans are in play for a given
|
|
|
|
|
/// diagnostic report.
|
|
|
|
|
Note,
|
|
|
|
|
|
|
|
|
|
/// Additional advice to the user that may help in debugging or fixing a
|
|
|
|
|
/// problem.
|
|
|
|
|
///
|
|
|
|
|
/// These messages may suggest concrete fixes and are intended to
|
|
|
|
|
/// hopefully replace having to request advice from a human.
|
|
|
|
|
/// Unlike other severity levels which provide concrete factual
|
|
|
|
|
/// information,
|
|
|
|
|
/// help messages may be more speculative.
|
2022-04-29 12:10:32 -04:00
|
|
|
|
#[default]
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
Help,
|
|
|
|
|
}
|
|
|
|
|
|
2022-10-21 15:35:27 -04:00
|
|
|
|
impl Level {
|
|
|
|
|
/// Whether this error level represents an error.
|
|
|
|
|
pub fn is_error(self) -> bool {
|
|
|
|
|
self <= Self::Error
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
impl Display for Level {
|
|
|
|
|
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
|
|
|
|
match self {
|
|
|
|
|
Level::InternalError => write!(f, "internal error"),
|
|
|
|
|
Level::Error => write!(f, "error"),
|
|
|
|
|
Level::Note => write!(f, "note"),
|
|
|
|
|
Level::Help => write!(f, "help"),
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// A label associated with a report or [`Span`].
|
|
|
|
|
///
|
|
|
|
|
/// See [`AnnotatedSpan`].
|
|
|
|
|
#[derive(Debug, PartialEq, Eq, Clone)]
|
2022-04-22 13:23:53 -04:00
|
|
|
|
pub struct Label<'a>(Cow<'a, str>);
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
|
2022-04-22 13:23:53 -04:00
|
|
|
|
impl<'a> Display for Label<'a> {
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
|
|
|
|
Display::fmt(&self.0, f)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2022-04-22 13:23:53 -04:00
|
|
|
|
impl<'a> From<String> for Label<'a> {
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
fn from(s: String) -> Self {
|
2022-04-22 13:23:53 -04:00
|
|
|
|
Self(Cow::Owned(s))
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2022-05-25 14:20:10 -04:00
|
|
|
|
impl<'a> From<&'a String> for Label<'a> {
|
|
|
|
|
fn from(s: &'a String) -> Self {
|
|
|
|
|
Self(Cow::Borrowed(s))
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2022-04-22 13:23:53 -04:00
|
|
|
|
impl<'a> From<&'a str> for Label<'a> {
|
|
|
|
|
fn from(s: &'a str) -> Self {
|
|
|
|
|
Self(Cow::Borrowed(s))
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// A span with an associated severity level and optional label.
|
|
|
|
|
///
|
|
|
|
|
/// Annotated spans are intended to guide users through debugging a
|
|
|
|
|
/// diagnostic message by describing important source locations that
|
|
|
|
|
/// contribute to a given diagnostic event.
|
|
|
|
|
#[derive(Debug, PartialEq, Eq, Clone)]
|
2022-04-22 13:23:53 -04:00
|
|
|
|
pub struct AnnotatedSpan<'l>(Span, Level, Option<Label<'l>>);
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
|
2022-04-22 13:23:53 -04:00
|
|
|
|
impl<'l> AnnotatedSpan<'l> {
|
|
|
|
|
pub fn with_help<L: Into<Label<'l>>>(
|
|
|
|
|
self,
|
|
|
|
|
label: L,
|
|
|
|
|
) -> [AnnotatedSpan<'l>; 2] {
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
let span = self.0;
|
|
|
|
|
[self, span.help(label)]
|
|
|
|
|
}
|
2022-06-13 11:17:21 -04:00
|
|
|
|
|
|
|
|
|
/// The [`Span`] with which the annotation is associated.
|
|
|
|
|
pub fn span(&self) -> Span {
|
|
|
|
|
match self {
|
|
|
|
|
AnnotatedSpan(span, ..) => *span,
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// A reference to the label of the annotation,
|
|
|
|
|
/// if available.
|
|
|
|
|
pub fn label(&self) -> Option<&Label<'l>> {
|
|
|
|
|
match self {
|
|
|
|
|
AnnotatedSpan(.., label) => label.as_ref(),
|
|
|
|
|
}
|
|
|
|
|
}
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
}
|
|
|
|
|
|
2022-04-22 13:23:53 -04:00
|
|
|
|
impl<'l> From<AnnotatedSpan<'l>> for Vec<AnnotatedSpan<'l>> {
|
|
|
|
|
fn from(x: AnnotatedSpan<'l>) -> Self {
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
vec![x]
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
pub trait Annotate: Sized {
|
|
|
|
|
/// Annotate a [`Span`] with a severity [`Level`] and an optional
|
|
|
|
|
/// [`Label`] to display alongside of it.
|
|
|
|
|
///
|
|
|
|
|
/// You may wish to use one of the more specific methods that provide a
|
|
|
|
|
/// more pleasent interface.
|
|
|
|
|
fn annotate(self, level: Level, label: Option<Label>) -> AnnotatedSpan;
|
|
|
|
|
|
|
|
|
|
/// Annotate a span as an internal error that the user is not expected
|
|
|
|
|
/// to be able to resolve,
|
|
|
|
|
/// but may be able to work around.
|
|
|
|
|
///
|
|
|
|
|
/// Since internal errors are one of the work things that can happen to
|
|
|
|
|
/// a user of a programming language,
|
|
|
|
|
/// given that they can only work around it,
|
|
|
|
|
/// this method mandates a help label that provides additional
|
|
|
|
|
/// context and a possible workaround.
|
2022-04-22 13:23:53 -04:00
|
|
|
|
fn internal_error<'l, L: Into<Label<'l>>>(
|
|
|
|
|
self,
|
|
|
|
|
label: L,
|
|
|
|
|
) -> AnnotatedSpan<'l> {
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
self.annotate(Level::InternalError, Some(label.into()))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Annotate a span with a clarifying label styled as an error.
|
|
|
|
|
///
|
|
|
|
|
/// This label is intended to augment the error message to help guide
|
|
|
|
|
/// the user to a resolution.
|
|
|
|
|
/// If the label does not include additional _useful_ information over
|
|
|
|
|
/// the generic message,
|
|
|
|
|
/// then it may be omitted in favor of `Annotate::mark_error` to
|
|
|
|
|
/// simply mark the location of the error.
|
|
|
|
|
///
|
|
|
|
|
/// (This is not named `err` since it does not return an [`Err`].)
|
2022-04-22 13:23:53 -04:00
|
|
|
|
fn error<'l, L: Into<Label<'l>>>(self, label: L) -> AnnotatedSpan<'l> {
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
self.annotate(Level::Error, Some(label.into()))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Like [`Annotate::error`],
|
|
|
|
|
/// but only styles the span as a [`Level::Error`] without attaching a
|
|
|
|
|
/// label.
|
|
|
|
|
///
|
|
|
|
|
/// This may be appropriate when a label would provide no more useful
|
|
|
|
|
/// information and would simply repeat the generic error text.
|
|
|
|
|
/// With that said,
|
|
|
|
|
/// if the repeat message seems psychologically beneficial in context,
|
|
|
|
|
/// you may wish to use [`Annotate::error`] anyway.
|
2022-04-22 13:23:53 -04:00
|
|
|
|
fn mark_error(self) -> AnnotatedSpan<'static> {
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
self.annotate(Level::Error, None)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Supplemental annotated span providing additional context for another
|
|
|
|
|
/// span.
|
|
|
|
|
///
|
|
|
|
|
/// For example,
|
|
|
|
|
/// if an error is related to a conflict with how an identifier is
|
|
|
|
|
/// defined,
|
|
|
|
|
/// then a note span may indicate the location of the identifier
|
|
|
|
|
/// definition.
|
2022-04-22 13:23:53 -04:00
|
|
|
|
fn note<'l, L: Into<Label<'l>>>(self, label: L) -> AnnotatedSpan<'l> {
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
self.annotate(Level::Note, Some(label.into()))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Provide additional information that may be used to help the user in
|
|
|
|
|
/// debugging or fixing a diagnostic.
|
|
|
|
|
///
|
|
|
|
|
/// While the other severity levels denote factual information,
|
|
|
|
|
/// this provides more loose guidance.
|
|
|
|
|
/// It may also include concrete suggested fixes.
|
2022-04-22 13:23:53 -04:00
|
|
|
|
fn help<'l, L: Into<Label<'l>>>(self, label: L) -> AnnotatedSpan<'l> {
|
tamer: diagnose: Introduction of diagnostic system
This is a working concept that will continue to evolve. I wanted to start
with some basic output before getting too carried away, since there's a lot
of potential here.
This is heavily influenced by Rust's helpful diagnostic messages, but will
take some time to realize a lot of the things that Rust does. The next step
will be to resolve line and column numbers, and then possibly include
snippets and underline spans, placing the labels alongside them. I need to
balance this work with everything else I have going on.
This is a large commit, but it converts the existing Error Display impls
into Diagnostic. This separation is a bit verbose, so I'll see how this
ends up evolving.
Diagnostics are tied to Error at the moment, but I imagine in the future
that any object would be able to describe itself, error or not, which would
be useful in the future both for the Summary Page and for query
functionality, to help developers understand the systems they are writing
using TAME.
Output is integrated into tameld only in this commit; I'll add tamec
next. Examples of what this outputs are available in the test cases in this
commit.
DEV-10935
2022-04-13 14:41:54 -04:00
|
|
|
|
self.annotate(Level::Help, Some(label.into()))
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<S: Into<Span>> Annotate for S {
|
|
|
|
|
fn annotate(self, level: Level, label: Option<Label>) -> AnnotatedSpan {
|
|
|
|
|
AnnotatedSpan(self.into(), level, label)
|
|
|
|
|
}
|
|
|
|
|
}
|