1
0
Fork 0
Commit Graph

622 Commits (27d570578d281fc43b2d7386ff6a440bc9a65e92)

Author SHA1 Message Date
Mike Gerwitz 27d570578d quicksave: Remove saving and restoring of state
The quicksave feature was added back in 2011 when the framework was somewhat
unstable---we were taking calls from users and it wasn't a pleasent
experience to tell them that they had to refresh the page to work around
some issue with bad state, and lose all unsaved data.

This feature is now more trouble than it's worth, since it causes a number
of bugs and can even cause data corruption.  If this is reintroduced in the
future, I'd prefer it be done by periodically saving quote state after every
or a few bucket modifications, to permit Meteor-like features.

This keeps the feature available on the client as a heartbeat for quote
locking; this can be removed in the future when we handle distributed
locking.

* src/client/Client.js (_changeQuote): Stop setting quicksave data from
    request.
  (_mergeQuickSaveData): Remove now-unused method.
  (_createUi): Stop merging quicksave data on render.
  (saveStaging): Add note that this method is now only used as a heartbeat.
* src/client/quote/ClientQuote.js (saveStaging): Add comment indicating that
    this is now used for a heartbeat.
  (setQuickSaveData, getQuickSaveData): Remove methods.
* src/quote/BaseQuote.js (_quickSaveData): Remove field.
  (setQuickSaveData, getQuickSaveData): Remove methods.
* src/server/Server.js (initQuote): Do not create or initialize quicksave
    data.
  (handleQuickSave): Remove method.
* src/server/daemon/controller.js (doRoute): Return empty reply without
    processing quicksave data.  Continue touching session to retain quote
    lock.
* src/server/db/MongoServerDao.js (saveQuote): Do not clear quicksave.
  (quickSaveQuote): Remove method.
2019-09-04 11:59:36 -04:00
Mike Gerwitz e058c8b509 Copyright range update
All files now have the same range, beginning from the conception of this
project.
2019-08-30 09:41:35 -04:00
Mike Gerwitz 2c49156ba3 controller: Add missing returns
This was broken when the controller was made async; the returns were
converted into resolves.
2019-08-28 15:17:04 -04:00
Schaffer, Austin f16d8f53ec [DEV-5752] Allow override for dynamic submit messages
See merge request floss/liza!61
2019-08-01 15:53:13 -04:00
Schaffer, Austin 858efdce84 [DEV-5752] Allow override for dynamic submit messages 2019-08-01 15:53:13 -04:00
Goldsmith, Mark 20b06ee64d [DEV-5618] Expose meta bucket to init route
See merge request floss/liza!60
2019-08-01 13:37:31 -04:00
Mark Goldsmith 6e99e65167 [DEV-5618] Expose meta bucket to init route 2019-08-01 12:20:22 -04:00
Sarah Chintomby c808cbce19 Merge branch 'jira-5546' into 'master'
[DEV-5546]  relativeDate method should work when using an edge case for the month

See merge request floss/liza!59
2019-06-18 12:32:56 -04:00
Sarah Chintomby c55235d7d4 [DEV-5546] Move edge case code for month 2019-06-18 12:14:36 -04:00
Sarah Chintomby 716f2b1a32 [DEV-5546] Update to use setUTCDate 2019-06-18 12:14:36 -04:00
Sarah Chintomby 3372e433d7 [DEV-5546] Update getdate to universal time 2019-06-18 12:14:36 -04:00
Sarah Chintomby 8f0b12bd3a [DEV-5546] Change getdate to getUTCDate 2019-06-18 12:14:36 -04:00
Sarah Chintomby 53f3e2317e [DEV-5546] Fix calc relativedate for day and also month concerning edge cases 2019-06-18 12:14:36 -04:00
Mike Gerwitz 5ad78461de HACKING: Mention semver 2019-06-17 10:55:30 -04:00
Chase Gregory 823e91c8bb [DEV-5333] Expose formatted expiration date 2019-06-17 10:25:56 -04:00
Austin Schaffer 9637fc22e1 [DEV-5333] Pass last rated date from the server quote back to the client quote
Correct and add more elaborate tests for RateEventHandler
2019-06-17 08:28:19 -04:00
Austin Schaffer 23889cbfca [DEV-5333] Use the correct function for day calculations 2019-06-14 10:40:49 -04:00
Austin Schaffer 723a7f7ff7 [DEV-5333] Expose initialRatedDate to the client from the bucket
[DEV-5333] WIP

Add RateEventHandlerTest and fix RatingServiceSubmitNotifyTest

WIP: Add RateEventHandlerTest

Add stubs for RateEventHandlerTest

Finish RateEventHandlerTest

Move done to fix test bug
2019-06-14 10:40:46 -04:00
Joseph Frazer 2f0fea8f49 Revert "[DEV-5492] Do not unserialize PHP objects in _sf2_attributes"
This reverts commit 981ba45d7c, reversing
changes made to e5917418fa.
2019-06-11 10:36:07 -04:00
Joseph Frazer 981ba45d7c [DEV-5492] Do not unserialize PHP objects in _sf2_attributes
Merge branch 'jira-5492'

* jira-5492:
  Revert "[DEV-5492] Add basic tests for UserSession.js"
  [DEV-5492] Do not unserialize PHP objects in _sf2_attributes
  [DEV-5492] Add basic tests for UserSession.js
2019-06-10 13:28:49 -04:00
Joseph Frazer 2b2b3fe78c Revert "[DEV-5492] Add basic tests for UserSession.js"
This reverts commit 29822599d6.
2019-06-10 11:52:51 -04:00
Joseph Frazer 5b08c981c3 [DEV-5492] Do not unserialize PHP objects in _sf2_attributes
The PHP objects in the session from PHP7 cannot be unserialized. Since
they are not needed, we can safely ignore them.

Co-Authored-By: Jim Grundner <james.grundner@rtspecialty.com>
2019-06-10 11:19:04 -04:00
Joseph Frazer 29822599d6 [DEV-5492] Add basic tests for UserSession.js 2019-06-10 11:15:49 -04:00
Mark Goldsmith e5917418fa [DEV-5255] Fix setStartDate to use startData
See merge request floss/liza!56
2019-06-06 16:49:45 -04:00
Mark Goldsmith 6e65b1f1e6 [DEV-5255] Fix setStartDate to use startData 2019-06-06 15:29:01 -04:00
Corey Vollmer 8285fe629c [DEV-3514] Fix bug with expiration date calculation
See merge request floss/liza!55
2019-05-30 14:30:48 -04:00
Andrew Fanton 0be64040f8 [DEV-3514] Fix bug with expiration date calculation
The nature of this bug was two-fold:
1.) A new Date was being instantiated with seconds,
but the constructor expects milliseconds.
2.) The expiration period was not cast to a number,
causing an expression to concatenate strings instead of
adding numeric values; this greatly increased the actual
expiration date.
2019-05-30 14:29:55 -04:00
Corey Vollmer e8c468a13b Merge branch 'jira-5254' into 'master'
[DEV-5254] Expose last rated timestamp with other metadata

See merge request floss/liza!54
2019-05-30 14:26:37 -04:00
Austin Schaffer c1082d2a9d [DEV-5254] Expose lastPremDate for the data warehouse 2019-05-30 10:15:25 -04:00
Mike Gerwitz 6edd5297a2 Lock quotes past expiration date 2019-05-29 15:09:37 -04:00
Andrew Fanton f569a7e94d [DEV-3514] Display message explaining why quote is locked
Prior to this change, a single generic message was always shown simply
stating that the quote had been locked. These changes now allow for
different messages to be displayed in different circumstances.
2019-05-28 16:33:08 -04:00
Andrew Fanton 5a5c2ca629 [DEV-3514] Lock quotes that exceed expiration date 2019-05-28 16:33:05 -04:00
Corey Vollmer 14869d9041 [DEV-3514] Add more robust testing for BasicQuote
Also, updated README to include instructions on `npm install.`
2019-05-21 14:03:05 -04:00
Herbert Burzlaff 1ab1ecc2d4
Merge branch 'DEVOPS-151' 2019-05-16 16:12:55 -04:00
Herbert Burzlaff 6e336610d4
DEVOPS-151 - gitlab-ci - Splitting up make commands so that the console output has the test (make check) results last 2019-05-09 08:57:48 -04:00
Herbert Burzlaff 06d928b179
Switching docker build image to node:4-stretch
node:4 has issues with apt since debian made changes to the apt repo for jessie
2019-05-08 17:10:47 -04:00
Herbert Burzlaff 7ac88d6e55
DEVOPS-151: code changes to support mongodb HA (Replication) 2019-05-08 17:05:30 -04:00
Herbert Burzlaff c36bc5a42f
DEVOPS-151: Updating mongodb nodejs driver to 1.2.14 2019-05-07 20:03:15 +00:00
Mike Gerwitz c0feed41e9 src/calc/Calc.js (relativeDate): Default format to empty string
We shouldn't throw errors given an empty array for this value.

* src/calc/Calc.js (relativeDate): Default `format' in `_each' call.
2019-04-26 11:02:49 -04:00
Mike Gerwitz 90802edc03 RatingServicePublish: Publish to {queue=>exchange}
This now publishes to a fanout exchange instead of a queue, which allows
consumers to handle their own queue configuration.

This also adds some basic logging that was missing from the first version.

Note that I still don't consider this to be production-quality code; it's
missing tests, and there's still notes that need to be addressed.
2019-04-03 10:43:58 -04:00
Mark Goldsmith aedf8ceed8 RatingServicePublish:_sendMessage passes program_id 2019-03-27 15:01:24 -04:00
Mike Gerwitz 77ddbbef3b Exclusively use RatingServicePublish over submit URL 2019-03-26 11:01:16 -04:00
Mike Gerwitz 98d81c2f2f RatingServicePublish: Close connections after a timeout
Until we have a better option.

I really hate that all of this is rushed.
2019-03-21 16:34:41 -04:00
Mike Gerwitz c4591f681d Daemon: Return promise for post_rate reduction
This was causing a race condition in some environments.
2019-03-21 14:56:42 -04:00
Mike Gerwitz c92cab4044 package.json (dependencies)[amqplib]: Add
This should have been in the previous commit.
2019-03-21 14:56:26 -04:00
Mike Gerwitz 13a7f97f8f Proof-of-concept RatingServicePublish to queue post-rate 2019-03-21 14:08:35 -04:00
Mike Gerwitz b8801c039f RatingServicePublish: New trait (mostly proof-of-concept)
This is unfortunately not production-ready code, but we need to get
something out there in the meantime.  The RatingServicePublish's docblock
mentions some of the shortcomings, which will be addressed in the near
future.

There is also more documentation to come once we settle on an implementation.

DEV-4400
2019-03-21 14:08:00 -04:00
Mike Gerwitz 814b0ff3a0 Client: Fix forward-validation failure messages
Forward validation failures were never updated to use the new Failure
object, so they ended up showing the default message.  The problem was that
`ui.invalidateForm' was replacing the Failure object with a new one with an
empty message.

This change just does the same thing as the change and save events.

* src/client/Client.js (_forwardValidate): Invoke `#_genValidationMessages'
    and `_dataValidator.updateFailures'.  Stop calling `ui.invalidateForm'.
2019-03-07 16:13:36 -05:00
Mark Goldsmith 53078919bb [DEV-4452] Accordion margin applies to collapsable header only
See merge request floss/liza!51
2019-03-01 10:36:14 -05:00
Mark Goldsmith 04565a6559 [DEV-4452] Accordion margin applies to collapsable header only 2019-03-01 10:02:39 -05:00