[DEV-5546] Fix calc relativedate for day and also month concerning edge cases

src/calc/Calc.js

@@ -274,7 +274,7 @@ exports.relativeDate = function( data, value )
 
             // days
             case 'd':
-                date_new.setDate( date_new.getUTCDate() + +tval );
+                date_new.setDate( date_new.getDate() + +tval );
                 break;
 
             // seconds
@@ -286,6 +286,14 @@ exports.relativeDate = function( data, value )
                 return '';
         }
 
+        // when adding a month to the last day of the month
+        // make sure the new date is also the last day of the month
+        // and not the first day of the next
+        if( type === 'm' && date_new.getDate() !== now_day )
+        {
+            date_new.setDate(0);
+        }
+
         // return in the YYYY-MM-DD format, since that's what our fields are
         // formatted as
         return date_new.getFullYear() + '-'

test/calc/CalcTest.js

@@ -0,0 +1,72 @@
+/**
+ * Tests Calc
+ *
+ *  Copyright (C) 2017 R-T Specialty, LLC.
+ *
+ *  This file is part of liza.
+ *
+ *  liza is free software: you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation, either version 3 of the License, or
+ *  (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+var liza         = require( '../..' ),
+    relativeDate = liza.calc.Calc.relativeDate,
+    expect       = require( 'chai' ).expect;
+
+
+describe( 'relativeDate', function()
+{
+    //returns a date relative to another date by adding a given value
+
+    it( 'assert 10 days is added, the date\'s month changes', function()
+    {
+        expect( relativeDate( ['2019-11-25'], ['10d'] ) )
+            .to.have.all.members( ['2019-12-05'] );
+    });
+
+    it( 'assert 10 days is added, the date\'s month and year changes', function()
+    {
+        expect( relativeDate( ['2019-12-28'], ['10d'] ) )
+            .to.have.all.members( ['2020-01-07'] );
+    });
+
+    it( 'assert edge case 6 months is added, the date does not go into the 7th month', function()
+    {
+        expect( relativeDate( ['2019-12-31'], ['6m'] ) )
+            .to.have.all.members( ['2020-06-30'] );
+    });
+
+    it( 'assert edge case 3 months is added, the date does not go into the 4th month', function()
+    {
+        expect( relativeDate( ['2019-08-31'], ['3m'] ) )
+            .to.have.all.members( ['2019-11-30'] );
+    });
+
+    it( 'assert 2 years is added', function()
+    {
+        expect( relativeDate( ['2019-12-31'], ['2y'] ) )
+            .to.have.all.members( ['2021-12-31'] );
+    });
+
+    it( 'assert edge case february', function()
+    {
+        expect( relativeDate( ['2018-12-31'], ['2m'] ) )
+            .to.have.all.members( ['2019-02-28'] );
+    });
+
+    it( 'assert ege case february leap year', function()
+    {
+        expect( relativeDate( ['2019-12-31'], ['2m'] ) )
+            .to.have.all.members( ['2020-02-29'] );
+    });
+});