Mike Gerwitz
fda002d252
[ #25 ] Added tests to ensure proper data is passed to validateMethod()
2011-11-03 23:20:45 -04:00
Mike Gerwitz
6fd7ae8953
[ #25 ] Tests with no assertions will be marked incomplete
2011-11-03 22:25:00 -04:00
Mike Gerwitz
fdf630458a
[ #25 ] instanceof => typeof for functions; lib/
2011-11-03 22:00:18 -04:00
Mike Gerwitz
705e228842
[ #25 ] Added suite runner
...
- Getting closer to nice clean testing
2011-11-03 21:23:40 -04:00
Mike Gerwitz
4e2af2333d
[ #25 ] Now injecting MemberBuilderValidator into MemberBuilder
2011-11-02 23:28:23 -04:00
Mike Gerwitz
3912f2d369
[ #25 ] Began refactoring test-class_builder-static into new test case system
2011-11-02 23:23:13 -04:00
Mike Gerwitz
79d0c4a62c
[ #25 ] Began moving test-class-implement over to new test case system
2011-11-02 22:32:45 -04:00
Mike Gerwitz
f15fa03a3b
[ #25 ] Began moving test-class-visibility over to new test case style
2011-11-02 22:04:53 -04:00
Mike Gerwitz
48dbfea990
[ #25 ] Began moving test-class_builder-visibility over to new test case format
2011-11-02 21:37:28 -04:00
Mike Gerwitz
de78a472f0
[ #25 ] MemberBuilder/MethodTest - removed unnecessary test
2011-11-02 19:12:15 -04:00
Mike Gerwitz
110d937838
[ #25 ] Began converting test-class_builder-const to test case
...
- Not yet renaming, as the conversion is not yet complete
2011-11-02 19:11:12 -04:00
Mike Gerwitz
a0ba2feb33
[ #25 ] Removed transfered tests from test-class_builder-const
2011-10-30 14:22:17 -04:00
Mike Gerwitz
b063a91e40
[ #25 ] Added visibility de-escalation and escalation tests to MemberBuilderValidator for getters/setters
2011-10-30 12:06:09 -04:00
Mike Gerwitz
91332353e9
[ #25 ] Added attachInstanceOf TODO
2011-10-30 11:56:54 -04:00
Mike Gerwitz
08cb663833
[ #25 ] Refactored quickVisChangeTest to share code between each of the member test cases
2011-10-29 10:08:08 -04:00
Mike Gerwitz
3c676de55d
[ #25 ] Combined buildGetter() and buildSetter()
...
This helped to get rid of some unnecessary duplicate code and should also help
to improve performance slightly for getter/setter definitions.
2011-10-29 08:25:51 -04:00
Mike Gerwitz
02cd52cfb7
[ #25 ] Began refactoring getter/setter building into a single method (util.propParse)
...
I'm unsure as to why I originally placed them in separate methods. propParse() will
always find a getter at the same time it finds a setter, and vice versa, should they
both have been defined on the object.
2011-10-29 08:08:02 -04:00
Mike Gerwitz
2ba8e2c8f0
[ #25 ] Refactored common getter/setter code into common method within MemberBuilder
2011-10-29 07:47:22 -04:00
Mike Gerwitz
8433511f56
[ #25 ] Added visibility [de-]escalation tests for properties
2011-10-28 20:22:53 -04:00
Mike Gerwitz
31a7980e37
[ #25 ] Moved bulk of visibility escalation test into common file to be shared with other member tests
2011-10-28 20:22:14 -04:00
Mike Gerwitz
93021f3dbc
[ #25 ] Moved getter/setter validation tests into new test case
...
Much more elegant a test case now.
2011-10-28 00:22:50 -04:00
Mike Gerwitz
ad0343fb9b
[ #25 ] Moved getter/setter validation logic into MemberBuilderValidator
...
- Tests have not yet been moved
2011-10-28 00:08:22 -04:00
Mike Gerwitz
05df0b485c
[ #25 ] Moved single access modifier getter/setter test to VisibilityTest
2011-10-27 20:46:30 -04:00
Mike Gerwitz
f19a62e733
[ #25 ] Moved public default getter/setter test to new location
2011-10-27 20:43:56 -04:00
Mike Gerwitz
a959e99b06
[ #25 ] Removed replaced vis tests from test-emmber_builder-gettersetter
2011-10-27 19:53:43 -04:00
Mike Gerwitz
5959956a27
[ #25 ] this => _self replacements in MemberBuilder/VisibilityTest
2011-10-27 19:52:43 -04:00
Mike Gerwitz
11020a9d2a
[ #25 ] Minor typo fix in MemberBuilder/VisibilityTest
2011-10-27 19:51:28 -04:00
Mike Gerwitz
1ba160e51c
[ #25 ] Added getter/setter vis test to MemberBuilder/VisibilityTest
2011-10-27 19:50:13 -04:00
Mike Gerwitz
ce7853965e
[ #25 ] Combined separate property and method vis test
2011-10-27 19:28:36 -04:00
Mike Gerwitz
6d1cc06c27
[ #25 ] Finished refactoring MemberBuilder/MethodTest and removed inc-member_builder-common (no longer needed)
...
Finally feels like things are starting to come together.
It's rather interesting looking back. Each time I begin writing a piece of
software, I think to myself, "This is the best way to do it." Well, generally.
Perhaps the implementation could have been better, but I may not have had the
time. However, the general concept remains.
Each time I look back months later and find that I disagree with certain
decisions. I find certain implementations to be messy or poorly constructed. Or
perhaps I was just being lazy to begin with. Whatever the case, it is
comforting. It shows that one is continuing to learn and evolve.
Now, in the case of ease.js, we're working with a number of different factors in
regards to my perception of prior code quality. Primarily, I'm looking at a
basic implementation (in this case, I'm referring to test cases) that served as
a foundation that could be later evolved. I didn't have the time to devote to a
stronger solution. However, since the project has evolved so far past my
original expectations, a more sophisticated solution is needed in order to
simplify the overall design. That is what happened here.
Of course, we're also looking at a year's worth of additional, intimate
experience with a language.
Regardless of the reason, I love to see software evolve. Especially my own. It's
as if I'm watching my child grow. From that, I can get a great deal of
satisfaction.
One shouldn't expect perfection. But one should certainly aim for it.
2011-10-26 23:39:03 -04:00
Mike Gerwitz
88cff48599
[ #25 ] Moved remaining tests in test-member_builder into MemberBuilder/VisibilityTest
2011-10-26 22:12:28 -04:00
Mike Gerwitz
2d494d577e
[ #25 ] Removed test-member_builder-prop; all tests have been moved
2011-10-26 00:03:26 -04:00
Mike Gerwitz
e90699c805
[ #25 ] Added test to MemberBuilder/Visibility test to ensure members will be declared public by default (if no access modifier is given)
2011-10-25 23:47:06 -04:00
Mike Gerwitz
f4b8eb3589
[ #25 ] Added test in MemberBuilder/VisibilityTest to ensure multiple access modifiers are not used
2011-10-25 23:30:57 -04:00
Mike Gerwitz
3482eb4cd7
[ #25 ] Removed method hiding test (can restore when reimplementing)
2011-10-25 22:29:03 -04:00
Mike Gerwitz
625f62bbf1
[ #25 ] Moved MemberBuilderValidator property tests into new test case
2011-10-23 01:14:13 -04:00
Mike Gerwitz
6fc3d05166
[ #25 ] Moved quick keyword validation into shared MemberBuilderValidator test module
2011-10-23 01:11:09 -04:00
Mike Gerwitz
a91cb01998
[ #25 ] Moved MethodBuilder property validation into MemberBuilderValidator
...
- Tests have not yet been moved
2011-10-23 00:43:08 -04:00
Mike Gerwitz
5e46298e39
[ #25 ] Moved MemberBuilderValidator's quickFailureTest into its own file to share with upcoming property tests
2011-10-23 00:27:25 -04:00
Mike Gerwitz
0d0372cb87
[ #25 ] Adding proper dirname to combined tests
2011-10-23 00:22:43 -04:00
Mike Gerwitz
9b629b8b61
[ #25 ] Removed tests from MemberBuilder/MethodTest that have been refactored into MemberBuilderValidator/MethodTest
2011-10-23 00:06:22 -04:00
Mike Gerwitz
9fe26e7582
[ #25 ] Moved MemberBuilderValidator/MethodTest's helper functions into caseSetUp()
2011-10-22 16:49:51 -04:00
Mike Gerwitz
2da2247c86
[ #25 ] Added successful test to MemberBuilderValidator's method tests to ensure successful functionality is also tested
2011-10-22 16:47:09 -04:00
Mike Gerwitz
8ebcc3f1b3
[ #25 ] Removed duplicate code from MemberBuilderValidator method test
2011-10-22 16:37:58 -04:00
Mike Gerwitz
cf99aa88e8
[ #25 ] Added README.todo
2011-10-22 16:32:55 -04:00
Mike Gerwitz
a5e2a507f2
[ #25 ] Throwing error instead of method hiding; will implement in future
2011-10-22 13:57:17 -04:00
Mike Gerwitz
6e7e031ff9
[ #25 ] [ #25 ] Re-added accidently removed portion of test
2011-10-22 11:06:03 -04:00
Mike Gerwitz
f9b951ddb2
[ #25 ] [ #25 ] Began moving MemberBuilder validation rules into MemberBuilderValidator (moved method rules)
2011-10-22 01:00:45 -04:00
Mike Gerwitz
e6830b741f
[ #25 ] Now using keywords to compare visibility levels in validations to eliminiate fallback inconsistencies
...
Ironic, considering the current refactoring (not yet committed) of MemberBuilder to split validation logic into MemberBuilderValidator was partially to be able to easily override the fallback logic. It's a useful refactoring nonetheless, but it could have waited.
2011-10-22 00:32:59 -04:00
Mike Gerwitz
f6369ba2c4
[ #25 ] No longer using util.isAbstractMethod() for method validation
2011-10-22 00:13:51 -04:00