mikegerwitz
/
jstonic
1
0
Fork 0
Code Releases Activity

Exposed Evented#_hooksEvent as public #hooksEvent

events
Mike Gerwitz 2014-08-03 00:39:28 -04:00
parent 66e3d5b1ef
commit eeea892967
2 changed files with 52 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/event/Evented.js
View File

@ -193,7 +193,7 @@ module.exports = Trait( 'Evented',
else if ( typeof listener !== 'function' ) {
throw TypeError( "Event listener must be a function" );
}
else if ( this._hooksEvent( ev, listener ) )
else if ( this.hooksEvent( ev, listener ) )
{
throw Error(
`Listener has already been bound to event \`${ev}'`
@ -260,10 +260,10 @@ module.exports = Trait( 'Evented',
*
* @return {boolean} whether LISTENER hooks event EV
*/
_hooksEvent( ev, listener )
hooksEvent( ev, listener )
{
let levdata = listener[ _evid ];
return ( levdata && ( levdata[ ev ] !== undefined ) );
return !!( levdata && ( levdata[ ev ] !== undefined ) );
},

49
test/event/EventedTest.js
View File

@ -597,5 +597,54 @@ describe( 'event.Evented', () =>
} );
} );
} );
describe( '#hooksEvent', () =>
{
var ev = 'foo',
f;
beforeEach( () =>
{
// ensure fresh listener
f = () => {};
} );
it( 'recognizes listener for a hooked event', () =>
{
stub.evDefineEvents( [ ev ] )
.on( ev, f );
expect( stub.hooksEvent( ev, f ) ).to.be.true;
} );
it( 'does not recognize listener for non-hooked event', () =>
{
expect( stub.hooksEvent( ev, f ) ).to.be.false;
} );
/**
* Technically this test is sufficient to make the previous two
* redundant, but they are retained for clairty in debugging.
*/
it( 'does not recognize listeners of other events', () =>
{
var ev2 = 'bar',
f2 = () => {};
stub.evDefineEvents( [ ev, ev2 ] )
.on( ev, f )
.on( ev2, f2 );
expect( stub.hooksEvent( ev, f ) ).to.be.true;
expect( stub.hooksEvent( ev2, f ) ).to.be.false;
expect( stub.hooksEvent( ev, f2 ) ).to.be.false;
expect( stub.hooksEvent( ev2, f2 ) ).to.be.true;
} );
} );
} );