employer
/
tame
1
0
Fork 0
Code Packages Releases Activity

tamer: src::ir::asg::ident::Dim: Assert n<10 

This replaces a TODO with an assertion.
main
Mike Gerwitz 2021-09-29 16:26:41 -04:00
parent 6864fbc1cd
commit fa4181770f
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tamer/src/ir/asg/ident.rs
View File

@ -347,7 +347,10 @@ pub struct Dim(u8);
impl Dim {
pub fn from_u8(value: u8) -> Self {
// TODO: 0≤n<10
// We don't expect to format a value this large.
// In practice, it should never exceed 2.
assert!(value < 10, "Dim value cannot exceed 9");
Self(value)
}
}

10
tamer/src/ir/asg/object.rs
View File

@ -1022,7 +1022,7 @@ mod test {
#[test]
fn redeclare_compatible_resolves() {
let sym: SymbolId = "extern_re_pre".intern();
let kind = IdentKind::Class(Dim::from_u8(10));
let kind = IdentKind::Class(Dim::from_u8(2));
let src = Source {
desc: Some("okay".into()),
..Default::default()
@ -1040,7 +1040,7 @@ mod test {
#[test]
fn redeclare_compatible_resolves_post() {
let sym: SymbolId = "extern_re_post".intern();
let kind = IdentKind::Class(Dim::from_u8(10));
let kind = IdentKind::Class(Dim::from_u8(1));
let src = Source {
desc: Some("okay".into()),
..Default::default()
@ -1057,7 +1057,7 @@ mod test {
#[test]
fn redeclare_another_extern() {
let sym: SymbolId = "extern_extern".intern();
let kind = IdentKind::Class(Dim::from_u8(20));
let kind = IdentKind::Class(Dim::from_u8(0));
let src_first = Source {
desc: Some("first src".into()),
..Default::default()
@ -1083,7 +1083,7 @@ mod test {
#[test]
fn redeclare_post_incompatible_kind() {
let sym: SymbolId = "extern_re_bad_post".intern();
let kind = IdentKind::Class(Dim::from_u8(10));
let kind = IdentKind::Class(Dim::from_u8(2));
let src = Source {
desc: Some("bad kind".into()),
..Default::default()
@ -1127,7 +1127,7 @@ mod test {
#[test]
fn redeclare_pre_incompatible_kind() {
let sym: SymbolId = "extern_re_bad_pre".intern();
let kind_given = IdentKind::Class(Dim::from_u8(10));
let kind_given = IdentKind::Class(Dim::from_u8(1));
let src = Source {
desc: Some("bad kind".into()),
..Default::default()