From f5ba4b013b85afa9b9473fda5b528df475cf6959 Mon Sep 17 00:00:00 2001
From: Mike Gerwitz <mike.gerwitz@ryansg.com>
Date: Thu, 1 Jul 2021 13:54:34 -0400
Subject: [PATCH] summary: Make Summay Page compiler less chatty

It produces a lot of output that either results in spam (internal errors) or
pollutes the log with unnecessary information.
---
 RELEASES.md             |  7 ++++++
 src/current/summary.xsl | 53 -----------------------------------------
 2 files changed, 7 insertions(+), 53 deletions(-)

diff --git a/RELEASES.md b/RELEASES.md
index 94292789..d7a22154 100644
--- a/RELEASES.md
+++ b/RELEASES.md
@@ -14,6 +14,13 @@ commits that introduce the changes.  To make a new release, run
 `tools/mkrelease`, which will handle updating the heading for you.
 
 
+NEXT
+====
+Compiler
+--------
+- Make Summary Page less chatty.
+
+
 v18.0.1 (2021-06-24)
 ====================
 This is a minor maintenance release.
diff --git a/src/current/summary.xsl b/src/current/summary.xsl
index d7f2c332..651265c8 100644
--- a/src/current/summary.xsl
+++ b/src/current/summary.xsl
@@ -141,7 +141,6 @@
       <xsl:call-template name="gen-pkg-menu" />
 
       <!-- load preprocessed source file -->
-      <xsl:message>[summary] typsetting self...</xsl:message>
       <xsl:variable name="pkg-self" select="
           document( concat( @__rootpath, @name, '.xmlo' ), . )/lv:*
         " />
@@ -300,8 +299,6 @@
   <xsl:variable name="self" select="." />
   <xsl:variable name="name" select="@name" />
 
-  <xsl:message>[summary] building package list...</xsl:message>
-
   <div class="menu" id="pkgmenu">
     <!-- build our own menu -->
     <h1 id="pkg-{@name}" class="sym-ref sym-pkg">
@@ -330,13 +327,6 @@
         ]
       ">
 
-      <xsl:message>
-        <xsl:text>[summary] </xsl:text>
-        <xsl:value-of select="$name" />
-        <xsl:text> uses </xsl:text>
-        <xsl:value-of select="@src" />
-      </xsl:message>
-
       <!-- build package menu -->
       <xsl:variable name="result">
         <xsl:apply-templates select="$self" mode="gen-menu">
@@ -545,8 +535,6 @@
   <xsl:param name="path" />
   <xsl:param name="import-path" />
 
-  <xsl:message>[summary] [<xsl:value-of select="@name" />]</xsl:message>
-
   <!-- used as an anchor -->
   <xsl:attribute name="id">
     <xsl:text>pkg-</xsl:text>
@@ -649,13 +637,6 @@
     </xsl:if>
   </xsl:variable>
 
-  <xsl:call-template name="_debug">
-    <xsl:with-param name="text">
-      <xsl:text>processing </xsl:text>
-      <xsl:value-of select="local-name()" />
-    </xsl:with-param>
-  </xsl:call-template>
-
   <xsl:variable name="name" select="@name" />
 
   <xsl:variable name="deps" as="element( preproc:sym-dep )?"
@@ -872,15 +853,6 @@
 <xsl:template match="lv:typedef[ not( lv:union ) ]">
   <xsl:param name="heading" select="true()" />
 
-  <!-- output heading on first match -->
-  <xsl:if test="( @name = ../lv:typedef[1]/@name ) and $heading">
-    <xsl:call-template name="_debug">
-      <xsl:with-param name="text">
-        <xsl:text>processing typedefs</xsl:text>
-      </xsl:with-param>
-    </xsl:call-template>
-  </xsl:if>
-
   <fieldset class="typedef math-typeset-hover">
     <!-- used as an anchor -->
     <xsl:attribute name="id">
@@ -1031,15 +1003,6 @@
 <xsl:template match="lv:classify" priority="1">
   <xsl:variable name="as" select="@as" />
 
-  <!-- output heading on first match -->
-  <xsl:if test="@as = ../lv:classify[1]/@as">
-    <xsl:call-template name="_debug">
-      <xsl:with-param name="text">
-        <xsl:text>processing classifications</xsl:text>
-      </xsl:with-param>
-    </xsl:call-template>
-  </xsl:if>
-
   <fieldset class="class math-typeset-hover">
     <!-- used as an anchor -->
     <xsl:attribute name="id">
@@ -1334,15 +1297,6 @@
 <xsl:template match="lv:function">
   <xsl:variable name="name" select="@name" />
 
-  <!-- output heading on first match -->
-  <xsl:if test="@name = ../lv:function[1]/@name">
-    <xsl:call-template name="_debug">
-      <xsl:with-param name="text">
-        <xsl:text>processing functions</xsl:text>
-      </xsl:with-param>
-    </xsl:call-template>
-  </xsl:if>
-
   <xsl:variable name="deps" as="element( preproc:sym-dep )"
                 select="/lv:*/preproc:sym-deps/preproc:sym-dep[
                           @name=$name ]" />
@@ -1568,13 +1522,6 @@
       </xsl:when>
 
       <xsl:when test="not( $tex ) or $tex=''">
-        <xsl:message>
-          <xsl:text>[summary] internal: missing TeX symbol for `</xsl:text>
-            <xsl:value-of select="$name" />
-          <xsl:text>' within the context of `</xsl:text>
-            <xsl:value-of select="$deps/@name" />
-          <xsl:text>'</xsl:text>
-        </xsl:message>
         <xsl:text>?^!</xsl:text>
       </xsl:when>