From e52d6c1eb0fe8e6e1b95f3a5566d17c36da7b6c0 Mon Sep 17 00:00:00 2001
From: Mike Gerwitz <mike.gerwitz@rtspecialty.com>
Date: Wed, 29 Nov 2017 13:19:41 -0500
Subject: [PATCH] depgen: Add error for rate block name conflicts

This can occur during template expansion if the user is not careful in
ensuring that all generated blocks will have unique names.  The error was
not useful: it failed type validation, which results in an internal error in
the compiler (from the user's perspective) and outputs no useful information
to aid in debugging.

* src/current/include/depgen.xsl
  (preproc:depgen preproc:sym): User-friendly error if more than one rate
    element.
  [rate]: Allow multiple rate elements.
---
 src/current/include/depgen.xsl | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/current/include/depgen.xsl b/src/current/include/depgen.xsl
index 9b2424f4..ab8f30e3 100644
--- a/src/current/include/depgen.xsl
+++ b/src/current/include/depgen.xsl
@@ -275,9 +275,15 @@
   <xsl:variable name="pkg" as="element( lv:package )"
                 select="root(.)" />
 
-  <xsl:variable name="rate" as="element( lv:rate )"
+  <xsl:variable name="rate" as="element( lv:rate )*"
                 select="$pkg/lv:rate[ @yields=$name ]" />
 
+  <xsl:if test="count( $rate ) gt 1">
+    <xsl:message terminate="yes"
+                 select="'error: rate block name conflict:',
+                         string( $rate/@yields[1] )" />
+  </xsl:if>
+
   <xsl:apply-templates mode="preproc:depgen"
                        select="$rate" />
 </xsl:template>