From 7a6aef00b28f6b3de79edcbfe380e3c08196e49b Mon Sep 17 00:00:00 2001 From: Mike Gerwitz Date: Wed, 10 May 2023 11:28:19 -0400 Subject: [PATCH] tamer: nir::air::NirToAir: Note about intent to refactor The comment speaks for itself. My concern is that this will be especially off-putting to people looking at TAMER and wondering how one could possibly work with this system. DEV-13162 --- tamer/src/nir/air.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tamer/src/nir/air.rs b/tamer/src/nir/air.rs index 9802d809..d23a3972 100644 --- a/tamer/src/nir/air.rs +++ b/tamer/src/nir/air.rs @@ -113,6 +113,10 @@ impl ParseState for NirToAir { return Transition(Ready).ok(obj).with_lookahead(tok); } + // TODO: The intent is to refactor this monstrosity once we're far + // enough along that a clear pattern emerges. + // Part of this process has been deriving appropriate + // responsibilities betwen XIR->NIR, NIR->AIR, and AIR->ASG. match (self, tok) { (Ready, Open(Package, span)) => { Transition(Ready).ok(Air::PkgStart(span))