From 6a45b2c95aeb4060555f08a5b76b6e5aba62fe01 Mon Sep 17 00:00:00 2001
From: Mike Gerwitz <mike.gerwitz@rtspecialty.com>
Date: Wed, 11 Apr 2018 14:28:11 -0400
Subject: [PATCH 1/3] map: Tunnel symtable

Simplifies coming changes.

* src/current/compiler/map.xsl: Tunnel all `symtable' params.
---
 src/current/compiler/map.xsl | 39 ++++++++++++++++++------------------
 1 file changed, 20 insertions(+), 19 deletions(-)

diff --git a/src/current/compiler/map.xsl b/src/current/compiler/map.xsl
index e18c1e4b..e46230f2 100644
--- a/src/current/compiler/map.xsl
+++ b/src/current/compiler/map.xsl
@@ -136,9 +136,10 @@
 
       <!-- compile mapped -->
       <apply-templates select="./lvm:*" mode="lvmc:compile">
-        <with-param name="symtable" select="$pkg-with-symtable/preproc:symtable" />
         <with-param name="rater"    select="$rater" />
         <with-param name="type"     select="'map'" />
+        <with-param name="symtable" select="$pkg-with-symtable/preproc:symtable"
+                    tunnel="yes"/>
       </apply-templates>
 
       <!-- special fragment to be output as the foot -->
@@ -209,9 +210,10 @@
 
       <!-- compile mapped -->
       <apply-templates select="./lvm:*" mode="lvmc:compile">
-        <with-param name="symtable" select="$pkg-with-symtable/preproc:symtable" />
         <with-param name="rater"    select="$rater" />
         <with-param name="type"     select="'retmap'" />
+        <with-param name="symtable" select="$pkg-with-symtable/preproc:symtable"
+                    tunnel="yes"/>
       </apply-templates>
 
       <!-- special fragment to be output as the foot -->
@@ -251,7 +253,7 @@
   <!-- allow mappings to be overridden after import, which allows defaults
        to be set and then overridden -->
   <preproc:sym name=":{$type-prefix}:{$name}" virtual="true"
-               keep="true" type="{$type-prefix}" pollute="true">
+               type="{$type-prefix}" pollute="true">
 
     <!-- for consistency and cleanliness, only copy over if set -->
     <if test="@override='true'">
@@ -272,7 +274,8 @@
   Directly map an input to the output
 -->
 <template match="lvm:pass" mode="lvmc:compile" priority="5">
-  <param name="symtable" as="element( preproc:symtable )" />
+  <param name="symtable" as="element( preproc:symtable )"
+         tunnel="yes" />
   <param name="type"     as="xs:string" />
 
   <preproc:fragment id=":{$type}:{@name}">
@@ -310,7 +313,8 @@
   Maps an input to an output of a different name
 -->
 <template match="lvm:map[ @from ]" mode="lvmc:compile" priority="5">
-  <param name="symtable" as="element( preproc:symtable )" />
+  <param name="symtable" as="element( preproc:symtable )"
+         tunnel="yes" />
   <param name="type" />
 
   <!-- if src and dest are identical, then it may as well be lvm:pass -->
@@ -526,7 +530,6 @@
 
 
 <template match="lvm:map[*]" mode="lvmc:compile" priority="5">
-  <param name="symtable" as="element( preproc:symtable )" />
   <param name="rater" />
   <param name="type" as="xs:string"/>
 
@@ -536,9 +539,8 @@
     <text>']=</text>
 
       <apply-templates select="./lvm:*" mode="lvmc:compile">
-        <with-param name="symtable" select="$symtable" />
         <with-param name="rater" select="$rater" />
-        <with-param name="type" select="$type" />
+        <with-param name="type"  select="$type" />
       </apply-templates>
 
     <text>;</text>
@@ -651,7 +653,8 @@
 
 
 <template match="lvm:map//lvm:from[*]" mode="lvmc:compile" priority="5">
-  <param name="symtable" as="element( preproc:symtable )" />
+  <param name="symtable" as="element( preproc:symtable )"
+         tunnel="yes" />
   <param name="type"     as="xs:string" />
 
   <variable name="to" select="ancestor::lvm:map/@to" />
@@ -685,8 +688,7 @@
            since case comparisons are strict (===) -->
       <text>switch(''+val[i]){</text>
         <apply-templates mode="lvmc:compile">
-          <with-param name="symtable" select="$symtable" />
-          <with-param name="type"     select="$type" />
+          <with-param name="type" select="$type" />
         </apply-templates>
 
         <if test="not( lvm:default )">
@@ -760,7 +762,8 @@
 
 <template match="lvm:from/lvm:default"
           mode="lvmc:compile" priority="5">
-  <param name="symtable" as="element( preproc:symtable )" />
+  <param name="symtable" as="element( preproc:symtable )"
+         tunnel="yes" />
   <param name="type"     as="xs:string" />
 
   <sequence select="concat(
@@ -779,15 +782,13 @@
 
 
 <template match="lvm:map//lvm:from/lvm:translate" mode="lvmc:compile" priority="5">
-  <param name="symtable" as="element( preproc:symtable )" />
-  <param name="type"     as="xs:string" />
+  <param name="type" as="xs:string" />
 
   <text>case '</text>
     <value-of select="@key" />
   <text>':</text>
     <apply-templates select="." mode="lvmc:compile-translate">
-      <with-param name="symtable" select="$symtable" />
-      <with-param name="type"     select="$type" />
+      <with-param name="type" select="$type" />
     </apply-templates>
   <text> break;</text>
 </template>
@@ -795,7 +796,8 @@
 
 <template match="lvm:translate[ element() ]"
               mode="lvmc:compile-translate" priority="5">
-  <param name="symtable" as="element( preproc:symtable )" />
+  <param name="symtable" as="element( preproc:symtable )"
+         tunnel="yes" />
   <param name="type"     as="xs:string" />
 
   <sequence select="concat(
@@ -822,8 +824,7 @@
         </if>
 
         <apply-templates mode="lvmc:compile" select=".">
-          <with-param name="symtable" select="$symtable" />
-          <with-param name="type"     select="$type" />
+          <with-param name="type" select="$type" />
         </apply-templates>
       </for-each>
     <text>;</text>

From ba1faa74da3cf376d09ff56e88def93a93741ff5 Mon Sep 17 00:00:00 2001
From: Mike Gerwitz <mike.gerwitz@rtspecialty.com>
Date: Wed, 11 Apr 2018 14:30:08 -0400
Subject: [PATCH 2/3] map: Support `from' within `set'

This was just a matter of proxying `type'.

* src/current/compiler/map.xsl (lvmc:compile): Proxy `type' param.
---
 src/current/compiler/map.xsl | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/current/compiler/map.xsl b/src/current/compiler/map.xsl
index e46230f2..8ff1abf9 100644
--- a/src/current/compiler/map.xsl
+++ b/src/current/compiler/map.xsl
@@ -618,12 +618,16 @@
 </template>
 
 <template match="lvm:map//lvm:set[@ignore-empty='true']" mode="lvmc:compile" priority="3">
+  <param name="type" as="xs:string"/>
+
   <text>(function(){</text>
     <text>var ret=[]; var tmp;</text>
 
     <for-each select="./lvm:*">
       <text>tmp=</text>
-        <apply-templates select="." mode="lvmc:compile" />
+        <apply-templates select="." mode="lvmc:compile">
+          <with-param name="type" select="$type" />
+        </apply-templates>
       <text>;</text>
 
       <text>if(tmp&amp;&amp;tmp!=='0')ret.push(tmp);</text>
@@ -634,13 +638,17 @@
 </template>
 
 <template match="lvm:map//lvm:set" mode="lvmc:compile" priority="2">
+  <param name="type" as="xs:string"/>
+
   <text>[</text>
     <for-each select="./lvm:*">
       <if test="position() > 1">
         <text>,</text>
       </if>
 
-      <apply-templates select="." mode="lvmc:compile" />
+      <apply-templates select="." mode="lvmc:compile">
+        <with-param name="type" select="$type" />
+      </apply-templates>
     </for-each>
   <text>]</text>
 </template>

From 45540133566fc2cf94043503502eb33a5a9780e1 Mon Sep 17 00:00:00 2001
From: Mike Gerwitz <mike.gerwitz@rtspecialty.com>
Date: Wed, 11 Apr 2018 14:31:52 -0400
Subject: [PATCH 3/3] map: Support @index on all lvm:from

* src/current/compiler/map.xsl (lvmc:compile)[lvm:map//lvm:from[*]]: Output
    index if @index is set.
---
 src/current/compiler/map.xsl | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/current/compiler/map.xsl b/src/current/compiler/map.xsl
index 8ff1abf9..8a318ab9 100644
--- a/src/current/compiler/map.xsl
+++ b/src/current/compiler/map.xsl
@@ -737,6 +737,11 @@
   <text>})(input['</text>
     <value-of select="@name" />
   <text>']</text>
+  <if test="@index">
+    <text>[</text>
+    <value-of select="@index" />
+    <text>]</text>
+  </if>
 
   <if test="$nested">
     <text>[curindex]</text>