employer
/
tame
1
0
Fork 0
Code Packages Releases Activity

tamer: asg::graph::object::ObjectRelFrom: Remove trait 

ObjectRelTo is sufficient and, while I originally thought it was useful to
have it read left-to-right, it just ends up being a cognitive burden.

DEV-13597
main
Mike Gerwitz 2023-01-19 16:40:55 -05:00
parent ee30600f67
commit 50afb2d359
1 changed files with 2 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tamer/src/asg/graph/object.rs
View File

@ -452,26 +452,9 @@ impl<O: ObjectKind> From<ObjectIndex<O>> for Span {
/// construct graphs that adhere to this schema.
pub trait ObjectRelTo<OB: ObjectKind>: ObjectKind {}
/// Indicate that an [`ObjectKind`] `Self` can be related to
/// [`ObjectKind`] `OB` by creating an edge from `OB` to `Self`.
///
/// _This trait exists for notational convenience and is intended only to
/// derive a blanket [`ObjectRelTo`] implementation._
/// This is because `impl`s are of the form `impl T for O`,
/// but it is more natural to reason about directed edges left-to-write as
/// `(From) -> (To)`;
/// this trait allows `impl ObjectRelFrom<OA> for OB` rather than the
/// equivalent `impl ObjectRelTo<OB> for OA`.
trait ObjectRelFrom<OA: ObjectKind>: ObjectKind {}
impl<OA: ObjectKind, OB: ObjectKind> ObjectRelTo<OB> for OA where
OB: ObjectRelFrom<OA>
{
}
// This describes the object relationship portion of the ASG's ontology.
impl ObjectRelFrom<Ident> for Expr {}
impl ObjectRelFrom<Expr> for Expr {}
impl ObjectRelTo<Expr> for Ident {}
impl ObjectRelTo<Expr> for Expr {}
/// A container for an [`Object`] allowing for owned borrowing of data.
///