From 297bf4a506db4c5db082ce568ed4b18075aa886a Mon Sep 17 00:00:00 2001
From: Mike Gerwitz <mike.gerwitz@ryansg.com>
Date: Thu, 19 Oct 2023 12:43:17 -0400
Subject: [PATCH] preproc/symtable: Linear-time type resolution

This was optimized previously, having introduced
`@need-resolve-dtype`.  But, while that solved the problem for some
packages, it was not enough for a package with 40,000 symbols.

This introduces a map for typedefs' symbols and eliminates ~15s for that
package.

DEV-15114
---
 src/current/include/preproc/symtable.xsl | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/current/include/preproc/symtable.xsl b/src/current/include/preproc/symtable.xsl
index 8f1ca9f5..98cd028a 100644
--- a/src/current/include/preproc/symtable.xsl
+++ b/src/current/include/preproc/symtable.xsl
@@ -256,7 +256,10 @@
 
       <apply-templates mode="preproc:symtable-complete"
                            select="$newresult/preproc:sym">
-        <with-param name="syms" select="$newresult/preproc:sym" />
+        <with-param name="typedef-symtable-map" tunnel="yes"
+                    select="map:merge(
+                              for $sym in $newresult/preproc:sym[ @type = 'type' ]
+                                return map{ string( $sym/@name ) : $sym } ) " />
       </apply-templates>
     </preproc:symtable>
 
@@ -845,14 +848,13 @@
 
 <template mode="preproc:symtable-complete" priority="5"
           match="preproc:sym[ @need-resolve-dtype='true' ]">
-  <param name="syms" as="element( preproc:sym )*" />
+  <param name="typedef-symtable-map" as="map(*)" tunnel="yes" />
 
   <!-- attempt to derive type information from a typedef -->
   <!-- TODO: also check symbol table after import (post-process) -->
   <variable name="type" select="@dtype" />
   <variable name="typedef" as="element( preproc:sym )?"
-                select="$syms[ @type = 'type'
-                               and @name = $type ]" />
+            select="$typedef-symtable-map( $type )" />
 
   <if test="not( $typedef and $typedef/@dtype )">
     <message terminate="yes">