From 0989895ea63324d61d67063d68ff795455ebeaa6 Mon Sep 17 00:00:00 2001
From: Mike Gerwitz <gerwitm@lovullo.com>
Date: Fri, 7 Aug 2015 15:01:35 -0400
Subject: [PATCH] _map-else_ error when _map_/@default@ already provided

---
 core/map.xml | 28 +++++++++++++++++++++++-----
 1 file changed, 23 insertions(+), 5 deletions(-)

diff --git a/core/map.xml b/core/map.xml
index de2c7bc0..6a010e31 100644
--- a/core/map.xml
+++ b/core/map.xml
@@ -52,20 +52,25 @@
       <text></text>
     </param>
 
-    <param name="@default@" desc="Default value" />
+    <!-- used in param-meta for _map-else_, so let's make the default
+         clear -->
+    <param name="@default@" desc="Default value">
+      <text></text>
+    </param>
 
 
     <c:cases label="@label@">
       <param-copy name="@values@">
-        <param-meta name="map_param" value="@name@" />
-        <param-meta name="map_index" value="@index@" />
+        <param-meta name="map_param"   value="@name@" />
+        <param-meta name="map_index"   value="@index@" />
+        <param-meta name="map_default" value="@default@" />
       </param-copy>
 
-      <if name="@default@">
+      <unless name="@default@" eq="">
         <c:otherwise>
           <c:const value="@default@" type="integer" desc="No mapping" />
         </c:otherwise>
-      </if>
+      </unless>
     </c:cases>
   </template>
 
@@ -156,6 +161,19 @@
       <text></text>
     </param>
 
+    <param name="@_map-default@" desc="_map_-specified default">
+      <param-inherit meta="map_default" />
+    </param>
+
+
+    <!-- provide a more friendly error; otherwise, they'd get an error
+         from having two c:otherwise nodes, which would be confusing -->
+    <unless name="@_map-default@" eq="">
+      <error>
+        A default value was already provided by _map-set_/@default@
+      </error>
+    </unless>
+
 
     <c:otherwise>
       <if name="@value@">