2021-10-12 10:30:02 -04:00
|
|
|
// Benchmarking of sorting of ASG into xmle sections
|
|
|
|
//
|
2023-01-17 23:09:25 -05:00
|
|
|
// Copyright (C) 2014-2023 Ryan Specialty, LLC.
|
2021-10-12 10:30:02 -04:00
|
|
|
//
|
|
|
|
// This file is part of TAME.
|
|
|
|
//
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
|
|
// it under the terms of the GNU General Public License as published by
|
|
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
|
|
// (at your option) any later version.
|
|
|
|
//
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
// GNU General Public License for more details.
|
|
|
|
//
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
|
|
|
#![feature(test)]
|
|
|
|
|
|
|
|
extern crate tamer;
|
|
|
|
extern crate test;
|
|
|
|
|
|
|
|
use test::Bencher;
|
|
|
|
|
2022-12-15 12:07:58 -05:00
|
|
|
pub(crate) use tamer::{
|
|
|
|
asg::{DefaultAsg, IdentKind, Source},
|
|
|
|
ld::xmle::{lower::sort, Sections},
|
|
|
|
num::Dtype,
|
|
|
|
parse::util::SPair,
|
|
|
|
span::UNKNOWN_SPAN,
|
tamer: Integrate clippy
This invokes clippy as part of `make check` now, which I had previously
avoided doing (I'll elaborate on that below).
This commit represents the changes needed to resolve all the warnings
presented by clippy. Many changes have been made where I find the lints to
be useful and agreeable, but there are a number of lints, rationalized in
`src/lib.rs`, where I found the lints to be disagreeable. I have provided
rationale, primarily for those wondering why I desire to deviate from the
default lints, though it does feel backward to rationalize why certain lints
ought to be applied (the reverse should be true).
With that said, this did catch some legitimage issues, and it was also
helpful in getting some older code up-to-date with new language additions
that perhaps I used in new code but hadn't gone back and updated old code
for. My goal was to get clippy working without errors so that, in the
future, when others get into TAMER and are still getting used to Rust,
clippy is able to help guide them in the right direction.
One of the reasons I went without clippy for so long (though I admittedly
forgot I wasn't using it for a period of time) was because there were a
number of suggestions that I found disagreeable, and I didn't take the time
to go through them and determine what I wanted to follow. Furthermore, it
was hard to make that judgment when I was new to the language and lacked
the necessary experience to do so.
One thing I would like to comment further on is the use of `format!` with
`expect`, which is also what the diagnostic system convenience methods
do (which clippy does not cover). Because of all the work I've done trying
to understand Rust and looking at disassemblies and seeing what it
optimizes, I falsely assumed that Rust would convert such things into
conditionals in my otherwise-pure code...but apparently that's not the case,
when `format!` is involved.
I noticed that, after making the suggested fix with `get_ident`, Rust
proceeded to then inline it into each call site and then apply further
optimizations. It was also previously invoking the thread lock (for the
interner) unconditionally and invoking the `Display` implementation. That
is not at all what I intended for, despite knowing the eager semantics of
function calls in Rust.
Anyway, possibly more to come on that, I'm just tired of typing and need to
move on. I'll be returning to investigate further diagnostic messages soon.
2023-01-12 10:46:48 -05:00
|
|
|
sym::GlobalSymbolIntern,
|
2022-12-15 12:07:58 -05:00
|
|
|
};
|
2021-10-12 10:30:02 -04:00
|
|
|
|
2022-05-12 15:44:32 -04:00
|
|
|
type TestAsg = DefaultAsg;
|
2021-10-12 10:30:02 -04:00
|
|
|
|
2022-12-15 12:07:58 -05:00
|
|
|
fn interned_n(n: u16) -> Vec<SPair> {
|
|
|
|
(0..n)
|
|
|
|
.map(|i| SPair(i.to_string().intern(), UNKNOWN_SPAN))
|
|
|
|
.collect()
|
2021-10-12 10:30:02 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
#[bench]
|
|
|
|
fn sort_1_with_1_000_existing_supernode(bench: &mut Bencher) {
|
|
|
|
let mut sut = TestAsg::new();
|
|
|
|
let xs = interned_n(1_000);
|
|
|
|
|
|
|
|
let orefs = xs
|
|
|
|
.iter()
|
|
|
|
.map(|sym| {
|
|
|
|
sut.declare(
|
|
|
|
*sym,
|
2022-05-19 10:09:49 -04:00
|
|
|
IdentKind::Rate(Dtype::Integer),
|
2021-10-12 10:30:02 -04:00
|
|
|
Source::default(),
|
|
|
|
)
|
|
|
|
.unwrap()
|
|
|
|
})
|
|
|
|
.collect::<Vec<_>>();
|
|
|
|
|
|
|
|
let root = orefs[0];
|
|
|
|
|
|
|
|
// All edges from a single node.
|
|
|
|
orefs.iter().skip(1).for_each(|to| {
|
|
|
|
sut.add_dep(root, *to);
|
|
|
|
});
|
|
|
|
|
tamer: asg: Track roots on graph
Previously, since the graph contained only identifiers, discovered roots
were stored in a separate vector and exposed to the caller. This not only
leaked details, but added complexity; this was left over from the
refactoring of the proof-of-concept linker some time ago.
This moves the root management into the ASG itself, mostly, with one item
being left over for now in the asg_builder (eligibility classifications).
There are two roots that were added automatically:
- __yield
- __worksheet
The former has been removed and is now expected to be explicitly mapped in
the return map, which is now enforced with an extern in `core/base`. This
is still special, in the sense that it is explicitly referenced by the
generated code, but there's nothing inherently special about it and I'll
continue to generalize it into oblivion in the future, such that the final
yield is just a convention.
`__worksheet` is the only symbol of type `IdentKind::Worksheet`, and so that
was generalized just as the meta and map entries were.
The goal in the future will be to have this more under the control of the
source language, and to consolodate individual roots under packages, so that
the _actual_ roots are few.
As far as the actual ASG goes: this introduces a single root node that is
used as the sole reference for reachability analysis and topological
sorting. The edges of that root node replace the vector that was removed.
DEV-11864
2022-05-17 10:42:05 -04:00
|
|
|
sut.add_root(root);
|
|
|
|
|
2021-10-12 10:30:02 -04:00
|
|
|
bench.iter(|| {
|
tamer: asg: Track roots on graph
Previously, since the graph contained only identifiers, discovered roots
were stored in a separate vector and exposed to the caller. This not only
leaked details, but added complexity; this was left over from the
refactoring of the proof-of-concept linker some time ago.
This moves the root management into the ASG itself, mostly, with one item
being left over for now in the asg_builder (eligibility classifications).
There are two roots that were added automatically:
- __yield
- __worksheet
The former has been removed and is now expected to be explicitly mapped in
the return map, which is now enforced with an extern in `core/base`. This
is still special, in the sense that it is explicitly referenced by the
generated code, but there's nothing inherently special about it and I'll
continue to generalize it into oblivion in the future, such that the final
yield is just a convention.
`__worksheet` is the only symbol of type `IdentKind::Worksheet`, and so that
was generalized just as the meta and map entries were.
The goal in the future will be to have this more under the control of the
source language, and to consolodate individual roots under packages, so that
the _actual_ roots are few.
As far as the actual ASG goes: this introduces a single root node that is
used as the sole reference for reachability analysis and topological
sorting. The edges of that root node replace the vector that was removed.
DEV-11864
2022-05-17 10:42:05 -04:00
|
|
|
drop(sort(&sut, Sections::new()));
|
2021-10-12 10:30:02 -04:00
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
#[bench]
|
|
|
|
fn sort_1_with_1_000_existing_one_edge_per_node_one_path(bench: &mut Bencher) {
|
|
|
|
let mut sut = TestAsg::new();
|
|
|
|
let xs = interned_n(1_000);
|
|
|
|
|
|
|
|
let orefs = xs
|
|
|
|
.iter()
|
|
|
|
.map(|sym| {
|
|
|
|
sut.declare(
|
|
|
|
*sym,
|
2022-05-19 10:09:49 -04:00
|
|
|
IdentKind::Rate(Dtype::Integer),
|
2021-10-12 10:30:02 -04:00
|
|
|
Source::default(),
|
|
|
|
)
|
|
|
|
.unwrap()
|
|
|
|
})
|
|
|
|
.collect::<Vec<_>>();
|
|
|
|
|
|
|
|
// Note that there's no `cycle` call on the iterator, like the
|
|
|
|
// above tests, to make sure we don't create a cycle on the
|
|
|
|
// graph.
|
|
|
|
orefs
|
|
|
|
.iter()
|
|
|
|
.zip(orefs.iter().skip(1))
|
|
|
|
.for_each(|(from, to)| {
|
|
|
|
sut.add_dep(*from, *to);
|
|
|
|
});
|
|
|
|
|
|
|
|
let root = orefs[0];
|
|
|
|
|
tamer: asg: Track roots on graph
Previously, since the graph contained only identifiers, discovered roots
were stored in a separate vector and exposed to the caller. This not only
leaked details, but added complexity; this was left over from the
refactoring of the proof-of-concept linker some time ago.
This moves the root management into the ASG itself, mostly, with one item
being left over for now in the asg_builder (eligibility classifications).
There are two roots that were added automatically:
- __yield
- __worksheet
The former has been removed and is now expected to be explicitly mapped in
the return map, which is now enforced with an extern in `core/base`. This
is still special, in the sense that it is explicitly referenced by the
generated code, but there's nothing inherently special about it and I'll
continue to generalize it into oblivion in the future, such that the final
yield is just a convention.
`__worksheet` is the only symbol of type `IdentKind::Worksheet`, and so that
was generalized just as the meta and map entries were.
The goal in the future will be to have this more under the control of the
source language, and to consolodate individual roots under packages, so that
the _actual_ roots are few.
As far as the actual ASG goes: this introduces a single root node that is
used as the sole reference for reachability analysis and topological
sorting. The edges of that root node replace the vector that was removed.
DEV-11864
2022-05-17 10:42:05 -04:00
|
|
|
sut.add_root(root);
|
|
|
|
|
2021-10-12 10:30:02 -04:00
|
|
|
bench.iter(|| {
|
tamer: asg: Track roots on graph
Previously, since the graph contained only identifiers, discovered roots
were stored in a separate vector and exposed to the caller. This not only
leaked details, but added complexity; this was left over from the
refactoring of the proof-of-concept linker some time ago.
This moves the root management into the ASG itself, mostly, with one item
being left over for now in the asg_builder (eligibility classifications).
There are two roots that were added automatically:
- __yield
- __worksheet
The former has been removed and is now expected to be explicitly mapped in
the return map, which is now enforced with an extern in `core/base`. This
is still special, in the sense that it is explicitly referenced by the
generated code, but there's nothing inherently special about it and I'll
continue to generalize it into oblivion in the future, such that the final
yield is just a convention.
`__worksheet` is the only symbol of type `IdentKind::Worksheet`, and so that
was generalized just as the meta and map entries were.
The goal in the future will be to have this more under the control of the
source language, and to consolodate individual roots under packages, so that
the _actual_ roots are few.
As far as the actual ASG goes: this introduces a single root node that is
used as the sole reference for reachability analysis and topological
sorting. The edges of that root node replace the vector that was removed.
DEV-11864
2022-05-17 10:42:05 -04:00
|
|
|
drop(sort(&sut, Sections::new()));
|
2021-10-12 10:30:02 -04:00
|
|
|
});
|
|
|
|
}
|