employer
/
liza
1
0
Fork 0
Code Releases Activity

ElementStyler: Remove jQuery for legacyradio value setting 

Continued eradication of jQuery for performance reasons.

* src/ui/ElementStyler.js (setValueByName): Do not use jQuery for
  legacyradio styling.  Throw exception on `change_event' argument set (this
  should no longer be used).
master
Mike Gerwitz 2018-02-02 16:55:50 -05:00
parent fa9ee5d340
commit d0bbc04218
1 changed files with 10 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/ui/ElementStyler.js
View File

@ -452,7 +452,13 @@ module.exports = Class( 'ElementStyler',
{
change_event = ( change_event === undefined ) ? true : change_event;
var $element;
// just to be sure before we fully remove this
if ( change_event !== false )
{
throw Error(
"ElementStyler#setValueByName change_event is being removed"
);
}
// set value
switch ( this._getElementType( name ) )
@ -486,33 +492,19 @@ module.exports = Class( 'ElementStyler',
var i = elements.length;
while ( i-- )
{
var $question = $( elements[ i ] );
if ( $question.attr( 'value' ) == value )
{
$question.attr( 'checked', true );
$element = $question;
}
else
{
$question.attr( 'checked', false );
}
const question = elements[ i ];
question.checked = ( question.value === ''+value );
}
break;
default:
$element = this.getElementByName(
const $element = this.getElementByName(
name, index, null, $context
);
$element.val( ''+( value ) );
}
if ( $element && change_event )
{
$element.trigger( 'change' );
}
return this;
},