employer
/
liza
1
0
Fork 0
Code Releases Activity

[DEV-3257] DataApiMediator: Set bucket data after stack clear 

Allowing the stack to clear ensures that (in practice) DelayedStagingBucket
is given a chance to do necessary processing before data are requested from
it by bucket hooks as a result of _this_ invocation, which in turn
results (in some cases) in infinite recursion.

* src/client/dapi/DataApiMediator.js (_updateFieldData): Allow stack to
    clear before invoking `quote.setData'.
* test/client/dapi/DataApiMediatorTest.js: Test respectively.

DEV-3257
master
Mike Gerwitz 2018-08-10 13:30:39 -04:00
parent 9243eeb8bc
commit b47deedf9c
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/client/dapi/DataApiMediator.js
View File

@ -177,7 +177,11 @@ module.exports = Class( 'DataApiMediator',
update[ name ] = field_update;
quote.setData( update );
// allow the stack to clear before setting data to allow any
// existing bucket processing to complete before hooks are kicked
// off yet again (which, in practice, could otherwise result in
// infinite recursion depending on what the hooks are doing)
setTimeout( () => quote.setData( update ) );
},

11
test/client/dapi/DataApiMediatorTest.js
View File

@ -319,7 +319,8 @@ describe( "DataApiMediator", () =>
{
it( label, done =>
{
let set_options = false;
let set_options = false;
let stack_cleared = false;
const quote = {
getDataByName( given_name )
@ -329,6 +330,9 @@ describe( "DataApiMediator", () =>
setData( given_data )
{
// we should have allowed the stack to clear first
expect( stack_cleared ).to.be.true;
expect( given_data ).to.deep.equal( expected );
// should have called setOptions by now
@ -382,6 +386,11 @@ describe( "DataApiMediator", () =>
dapi_manager.emit(
'updateFieldData', name, index, val_label, results
);
// #setData should be triggered after the stack clears to
// #mitigate issues with hooks causing too much / infinite
// #recursion on the bucket on the same stack
stack_cleared = true;
} );
} );