employer
/
liza
1
0
Fork 0
Code Releases Activity

HttpDataApi#request permits null data

master
Mike Gerwitz 2015-05-29 12:45:02 -04:00
parent 0599acc23a
commit a383a36bfc
2 changed files with 24 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/dapi/http/HttpDataApi.js
View File

@ -96,7 +96,8 @@ module.exports = Class( 'HttpDataApi' )
* DATA must be either a string or an object; the latter is treated as a
* key-value parameter list, which will have each key and value
* individually URI-encoded and converted into a string, delimited by
* ampersands.
* ampersands. `null` may be used to indicate that no data should be
* sent.
*
* In the event of an error, the first parameter is the error; otherwise, it
* is null. The return data shall not be used in the event of an error.
@ -114,6 +115,13 @@ module.exports = Class( 'HttpDataApi' )
*/
'virtual public request': function( data, callback )
{
// null is a good indicator of "I have no intent to send any data";
// empty strings and objects are not, since those are valid data
if ( data === null )
{
data = "";
}
this._validateDataType( data );
this._impl.requestData(
@ -158,9 +166,7 @@ module.exports = Class( 'HttpDataApi' )
{
var type = typeof data;
if ( ( data === null )
|| !( ( type === 'string' ) || ( type === 'object' ) )
)
if( !( ( type === 'string' ) || ( type === 'object' ) ) )
{
throw TypeError(
"Data must be a string of raw data or object containing " +

15
test/dapi/http/HttpDataApiTest.js
View File

@ -175,11 +175,24 @@ describe( 'HttpDataApi', function()
} );
it( 'accepts null data, converting to empty string', function()
{
expect( function()
{
Sut( dummy_url, 'GET', impl )
.request( null, function()
{
expect( impl.provided[ 2 ] ).to.equal( "" );
} );
} ).to.not.throw( Error );
} );
it( 'rejects all other data types', function()
{
var sut = Sut( dummy_url, 'GET', impl );
[ 123, null, Infinity, undefined, NaN, function() {} ]
[ 123, Infinity, undefined, NaN, function() {} ]
.forEach( function( data )
{
expect( function()