employer
/
liza
1
0
Fork 0
Code Releases Activity

Use HTMLElement#setAttribute in NaFieldStyler for IE<9 

element.style is not supported as an lvalue in IE<9.

All the rest of the sane world that doesn't support IE<9 should be laughing
at me in pity right now.

* src/ui/styler/NaFieldStyler.js (hideField):
Use HTMLElement#setAttribute instead of HTMLElement#style as an lvalue

* test/ui/styler/NaFieldStylerTest.js: Modify test cases to check for
invocation of setAttribute
master
Mike Gerwitz 2016-04-05 11:53:29 -04:00
parent 573e73cde9
commit a145bfe1f8
2 changed files with 42 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/ui/styler/NaFieldStyler.js
View File

@ -137,15 +137,18 @@ module.exports = Class( 'NaFieldStyler' )
{
this.addClass( element, 'hidden' );
// this is a workaround from the old days where jQuery would add
// This is a workaround from the old days where jQuery would add
// styles to hide elements, which we wanted to override; this can be
// removed once jQuery is eradicated from the framework
element.style = '';
// removed once jQuery is eradicated from the framework.
//
// setAttribute is intentional! IE<9 doesn't support element.style
// as an lvalue.
element.setAttribute( 'style', '' );
for ( var i in row )
{
this.addClass( row[ i ], 'hidden' );
row[ i ].style = '';
row[ i ].setAttribute( 'style', '' );
}
},

59
test/ui/styler/NaFieldStylerTest.js
View File

@ -29,9 +29,9 @@ describe( 'ui.styler.NaFieldStyler', function()
{
function testApplyHidden()
{
var element = { className: '' },
r1 = { className: '' },
r2 = { className: '' },
var element = stubEle( { className: '' } ),
r1 = stubEle( { className: '' } ),
r2 = stubEle( { className: '' } ),
row = [ r1, r2 ];
Sut().applyStyle( getStubField( element ), element, row );
@ -45,9 +45,9 @@ describe( 'ui.styler.NaFieldStyler', function()
function testApplyClear()
{
var element = { style: 'foo' },
r1 = { style: 'foo' },
r2 = { style: 'foo' },
var element = stubEle( { style: 'foo' } ),
r1 = stubEle( { style: 'foo' } ),
r2 = stubEle( { style: 'foo' } ),
row = [ r1, r2 ];
Sut().applyStyle( getStubField( element ), element, row );
@ -61,9 +61,9 @@ describe( 'ui.styler.NaFieldStyler', function()
function testRevokeHidden()
{
var element = { className: 'foo hidden' },
r1 = { className: 'foo hidden' },
r2 = { className: 'foo hidden' },
var element = stubEle( { className: 'foo hidden' } ),
r1 = stubEle( { className: 'foo hidden' } ),
r2 = stubEle( { className: 'foo hidden' } ),
row = [ r1, r2 ];
Sut().revokeStyle( getStubField( element ), element, row );
@ -78,9 +78,9 @@ describe( 'ui.styler.NaFieldStyler', function()
function testRevokeStyle()
{
var element = { style: 'foo' },
r1 = { style: 'foo' },
r2 = { style: 'foo' },
var element = stubEle( { style: 'foo' } ),
r1 = stubEle( { style: 'foo' } ),
r2 = stubEle( { style: 'foo' } ),
row = [ r1, r2 ];
Sut().revokeStyle( getStubField( element ), element, row );
@ -109,16 +109,16 @@ describe( 'ui.styler.NaFieldStyler', function()
it( 'does not set class on subfield parents', function()
{
var element = {
var element = stubEle( {
className: '',
parentElement: {
className: 'widget',
removeChild: function() {},
}
};
} );
var r1 = { className: '' },
r2 = { className: '' },
var r1 = stubEle( { className: '' } ),
r2 = stubEle( { className: '' } ),
row = [ r1, r2 ];
Sut().applyStyle( getStubField( element ), element, row );
@ -134,16 +134,16 @@ describe( 'ui.styler.NaFieldStyler', function()
it( 'does not clears style subfield parents', function()
{
var element = {
var element = stubEle( {
style: 'foo',
parentElement: {
className: 'widget',
removeChild: function() {},
}
};
} );
var r1 = { style: 'foo' },
r2 = { style: 'foo' },
var r1 = stubEle( { style: 'foo' } ),
r2 = stubEle( { style: 'foo' } ),
row = [ r1, r2 ];
Sut().applyStyle( getStubField( element ), element, row );
@ -160,7 +160,7 @@ describe( 'ui.styler.NaFieldStyler', function()
// f@#(& IE
it( 'removes subfield from DOM', function( done )
{
var element = {
var element = stubEle( {
style: '',
parentElement: {
className: 'widget',
@ -170,7 +170,7 @@ describe( 'ui.styler.NaFieldStyler', function()
done();
},
}
};
} );
Sut().applyStyle( getStubField( element ), element, [] );
} );
@ -233,9 +233,9 @@ describe( 'ui.styler.NaFieldStyler', function()
{
it( 'recognizes when applied', function()
{
var element = {
var element = stubEle( {
className: '',
};
} );
var sut = Sut(),
field = getStubField( element );
@ -320,3 +320,14 @@ function protSut()
}
} )();
}
function stubEle( obj )
{
obj.setAttribute = function( name, value )
{
obj[ name ] = value;
}
return obj;
}