From 8600c3beb71dd9b54ddf32efb634e696d761a08a Mon Sep 17 00:00:00 2001
From: Jeffrey Fisher <jeffrey.fisher@rtspecialty.com>
Date: Tue, 19 Jun 2018 09:57:50 -0400
Subject: [PATCH] [DEV-3192] Renamed variables and added test case

---
 src/program/ProgramInit.js      | 18 ++++++++----------
 test/program/ProgramInitTest.js | 14 ++++++++++++++
 2 files changed, 22 insertions(+), 10 deletions(-)

diff --git a/src/program/ProgramInit.js b/src/program/ProgramInit.js
index ce9477a..d4db00f 100644
--- a/src/program/ProgramInit.js
+++ b/src/program/ProgramInit.js
@@ -55,31 +55,29 @@ module.exports = Class( 'ProgramInit',
     'public init'( program, doc_data )
     {
         const defaults = program.defaults || {};
-
-        let data = doc_data || {};
-        let groups = program.meta.groups;
+        const data = doc_data || {};
+        const groups = program.meta.groups;
 
         Object.keys( program.groupExclusiveFields ).forEach( group =>
         {
-            let length = program.groupExclusiveFields[ group ].length;
+            let i = program.groupExclusiveFields[ group ].length;
 
-            while ( length-- )
+            while ( i-- )
             {
-                let field = program.groupExclusiveFields[ group ][ length ];
-                let defaultValue;
+                const field = program.groupExclusiveFields[ group ][ i ];
+                const default_value = defaults[ field ];
 
                 if ( !defaults.hasOwnProperty( field ))
                 {
                     continue;
                 }
 
-                defaultValue = defaults[ field ];
                 // Initialize with existing document data if any
 
                 // If no document data, initialize with default value
                 if ( data[ field ] === undefined )
                 {
-                    data[ field ] = [ defaultValue ];
+                    data[ field ] = [ default_value ];
                 }
 
                 // If min rows on the group is greater than the data
@@ -93,7 +91,7 @@ module.exports = Class( 'ProgramInit',
 
                     while ( index < groups[ group ].min )
                     {
-                        data[ field ][ index ] = defaultValue;
+                        data[ field ][ index ] = default_value;
                         index++;
                     }
                 }
diff --git a/test/program/ProgramInitTest.js b/test/program/ProgramInitTest.js
index a2d6d93..8d3ee90 100644
--- a/test/program/ProgramInitTest.js
+++ b/test/program/ProgramInitTest.js
@@ -85,6 +85,20 @@ describe( 'ProgramInit', () =>
                 bar: [ "baz" ],
             },
         },
+        {
+            label:    "keeps existing data with no defaults",
+            defaults: {},
+            meta: {
+                groups: {}
+            },
+            groupExclusiveFields: {
+                SomethingElse: [ "bar" ]
+            },
+            doc_data: { bar: [ "baz" ] },
+            expected: {
+                bar: [ "baz" ],
+            },
+        },
         {
             label:    "does not overwrite existing data with defaults",
             defaults: { foo: "init" },