employer
/
liza
1
0
Fork 0
Code Releases Activity

NaFieldStylerAnimation: Remove trait 

These animations are ugly and slow when there are many questions on a
step.  I've wanted them gone for quite some time, and now we don't have a
disagreement among developers.

* src/client/ClientDependencyFactory.js (createNaFieldStyler): Remove
  NaFieldStylerAnimation mixin.
* src/ui/styler/NaFieldStylerAnimation.js: Remove trait.
master
Mike Gerwitz 2018-02-01 14:12:15 -05:00
parent af7774a272
commit 799a74d7a1
2 changed files with 3 additions and 108 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/client/ClientDependencyFactory.js
View File

@ -1,7 +1,7 @@
/**
* Factory for Client dependencies
*
* Copyright (C) 2017 R-T Specialty, LLC.
* Copyright (C) 2017, 2018 R-T Specialty, LLC.
*
* This file is part of the Liza Data Collection Framework
*
@ -91,8 +91,7 @@ var Step = require( '../step/Step' ),
SidebarErrorStyler = require( '../ui/styler/SidebarErrorStyler' ),
ErrorFieldStyler = require( '../ui/styler/ErrorFieldStyler' ),
NaFieldStyler = require( '../ui/styler/NaFieldStyler' ),
NaFieldStylerAnimation = require( '../ui/styler/NaFieldStylerAnimation' ),
NaFieldStyler = require( '../ui/styler/NaFieldStyler' ),
DelegateEventHandler = require( './event/DelegateEventHandler' ),
@ -331,8 +330,7 @@ module.exports = Class( 'ClientDependencyFactory',
createNaFieldStyler: function()
{
return NaFieldStyler
.use( NaFieldStylerAnimation( jQuery ) )();
return NaFieldStyler();
},
createFormErrorBox: FormErrorBox,

103
src/ui/styler/NaFieldStylerAnimation.js
View File

@ -1,103 +0,0 @@
/**
* Animated N/A field styler
*
* Copyright (C) 2016 R-T Specialty, LLC.
*
* This file is part of liza.
*
* liza is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
var Trait = require( 'easejs' ).Trait,
NaFieldStyler = require( './NaFieldStyler' );
/**
* Sliding animations for field show/hide
*
* @todo Use CSS3 once we can drop support for IE<10
*/
module.exports = Trait.extend( NaFieldStyler,
{
/**
* jQuery instance
* @type {jQuery}
*/
'private _jquery': null,
/**
* Prepare mixin with jQuery instance
*
* @param {jQuery} jquery jQuery instance
*/
__mixin: function( jquery )
{
this._jquery = jquery;
},
/**
* Animate field display
*
* When a field becomes applicable, progressively increase its height
* ("slide down").
*
* @param {HTMLElement} element field DOM element
* @param {Array.<HTMLElement} row parent row elements
*
* @return {undefined}
*/
'override protected showField': function( element, row )
{
var $row = this._jquery( row ),
$element = this._jquery( element );
$row.stop( true, true );
this.__super( element, row );
// jQuery adds its own styling (e.g. display:none)
$element.show();
$row
.hide()
.slideDown( 500 );
},
/**
* Animate field hiding
*
* When a field becomes non-applicable, progressively decrease its
* height ("slide up").
*
* @param {HTMLElement} element field DOM element
* @param {Array.<HTMLElement} row parent row elements
*
* @return {undefined}
*/
'override protected hideField': function( element, row )
{
var _self = this,
all = [ element ].concat( row ),
$elements = this._jquery( all );
$elements.stop( true, true )
.slideUp( 500, function()
{
_self.hideField['super'].call( _self, element, row );
} );
}
} );