From cc79f8e1f337276b5ec638c5136a847315fed0e8 Mon Sep 17 00:00:00 2001 From: Mike Gerwitz Date: Thu, 9 Feb 2017 15:20:23 -0500 Subject: [PATCH] FieldVisibilityEventHandler: use new DataValidator API I updated DataValidator but never updated the caller. Damnit. It's an unfortunate side-effect of dynamic, loosely typed languages and mitigating it requires what should be boilerplate functional tests (in this case---functional tests are useful for many other integration aspects). * src/event/FieldVisibilityEventHandler.js (handle): Use updated DataValidator#clearFailures API, which has a different descriptor format. * test/event/FieldVisibilityEventHandlerTest.js: Update test. --- src/event/FieldVisibilityEventHandler.js | 2 +- test/event/FieldVisibilityEventHandlerTest.js | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/event/FieldVisibilityEventHandler.js b/src/event/FieldVisibilityEventHandler.js index aa5b33d..99e51c8 100644 --- a/src/event/FieldVisibilityEventHandler.js +++ b/src/event/FieldVisibilityEventHandler.js @@ -103,7 +103,7 @@ module.exports = Class( 'FieldVisibilityEventHandler' ) } } )(); - this._data_validator.clearFailures( [ field_name ] ); + this._data_validator.clearFailures( { [field_name]: indexes } ); indexes.forEach( field_i => action( field_name, field_i ) ); callback(); diff --git a/test/event/FieldVisibilityEventHandlerTest.js b/test/event/FieldVisibilityEventHandlerTest.js index 005e0e7..85b07c9 100644 --- a/test/event/FieldVisibilityEventHandlerTest.js +++ b/test/event/FieldVisibilityEventHandlerTest.js @@ -96,11 +96,12 @@ describe( 'FieldVisibilityEventHandler', () => it( 'clears failures on hidden fields', done => { - const name = 'foo_bar'; + const name = 'foo_bar'; + const fail_indexes = [ 0, 3 ]; const hide_data = { elementName: name, - indexes: [ 0 ], + indexes: fail_indexes, }; Sut( @@ -108,7 +109,7 @@ describe( 'FieldVisibilityEventHandler', () => createStubDataProvider( failures => { expect( failures ) - .to.deep.equal( [ name ] ) + .to.deep.equal( { [name]: fail_indexes } ); // we don't care about the rest of the processing at this // point