employer
/
liza
1
0
Fork 0
Code Releases Activity

HttpDataApi: Only serialize JSON on POST 

* src/dapi/http/HttpDataApi.js (_encodeKeys): JSON.stringify on POST.
* test/dapi/http/HttpDataApiTest.js: Update tests accordingly.
  Add POST test.
master
Mike Gerwitz 2017-08-07 11:29:13 -04:00
parent ae9c293518
commit 020ca01458
2 changed files with 22 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/dapi/http/HttpDataApi.js
View File

@ -206,6 +206,11 @@ module.exports = Class( 'HttpDataApi' )
{
var uri = '';
if ( this._method === 'POST' )
{
return JSON.stringify( obj );
}
// ES3 support
for ( var key in obj )
{

20
test/dapi/http/HttpDataApiTest.js
View File

@ -105,7 +105,7 @@ describe( 'HttpDataApi', function()
*/
it( 'delegates to provided HTTP implementation', function()
{
var method = 'POST',
var method = 'GET',
data = "ribbit",
c = function() {};
@ -127,7 +127,7 @@ describe( 'HttpDataApi', function()
{
it( 'converts data into encoded string', function()
{
var method = 'POST',
var method = 'GET',
data = { foo: "bar=baz", '&bar': "moo%cow" },
c = function() {};
@ -143,7 +143,7 @@ describe( 'HttpDataApi', function()
it( 'with no keys, results in empty string', function()
{
var method = 'POST',
var method = 'GET',
data = {},
c = function() {};
@ -151,6 +151,20 @@ describe( 'HttpDataApi', function()
expect( impl.provided[ 2 ] ).to.equal( "" );
} );
it( 'encodes JSON on POST', () =>
{
var method = 'POST',
data = { foo: 'bar' },
c = () => {};
Sut( dummy_url, method, impl ).request( data, c );
expect( impl.provided[ 2 ] ).to.equal(
JSON.stringify( data )
);
} );
} );