1
0
Fork 0
Commit Graph

387 Commits (8b74ed9f1b0261ec99fbd3fb0cc212a1e953aece)

Author SHA1 Message Date
Mike Gerwitz 8b74ed9f1b
Corrected a bug whereby getters were being inadvertently invoked by util.propParse()
Nasty; hopefully this was found before it did any harm to anyone else! This bug was discovered accidentally while I was debugging a separate issue.
2013-01-19 22:38:31 -05:00
Mike Gerwitz 02e22e64b9
Corrected warning console output invocation 2013-01-19 22:38:26 -05:00
Mike Gerwitz e67c14e8c3
Added support for static proxy methods
When the static keyword is provided, the proxy will use the static accessor
method to look up the requested member.
2012-05-03 14:13:47 -04:00
Mike Gerwitz d84b86b21b
Added `proxy' keyword support
The concept of proxy methods will become an important, core concept in ease.js
that will provide strong benefits for creating decorators and proxies, removing
boilerplate code and providing useful metadata to the system. Consider the
following example:

  Class( 'Foo',
  {
      // ...

      'public performOperation': function( bar )
      {
          this._doSomethingWith( bar );
          return this;
      },
  } );

  Class( 'FooDecorator',
  {
      'private _foo': null,

      // ...

      'public performOperation': function( bar )
      {
          return this._foo.performOperation( bar );
      },
  } );

In the above example, `FooDecorator` is a decorator for `Foo`. Assume that the
`getValueOf()` method is undecorated and simply needs to be proxied to its
component --- an instance of `Foo`. (It is not uncommon that a decorator, proxy,
or related class will alter certain functionality while leaving much of it
unchanged.) In order to do so, we can use this generic, boilerplate code

  return this.obj.func.apply( this.obj, arguments );

which would need to be repeated again and again for *each method that needs to
be proxied*. We also have another problem --- `Foo.getValueOf()` returns
*itself*, which `FooDecorator` *also* returns.  This breaks encapsulation, so we
instead need to return ourself:

  'public performOperation': function( bar )
  {
      this._foo.performOperation( bar );
      return this;
  },

Our boilerplate code then becomes:

  var ret = this.obj.func.apply( this.obj, arguments );
  return ( ret === this.obj )
      ? this
      : ret;

Alternatively, we could use the `proxy' keyword:

  Class( 'FooDecorator2',
  {
      'private _foo': null,

      // ...

      'public proxy performOperation': '_foo',
  } );

`FooDecorator2.getValueOf()` and `FooDecorator.getValueOf()` both perform the
exact same task --- proxy the entire call to another object and return its
result, unless the result is the component, in which case the decorator itself
is returned.

Proxies, as of this commit, accomplish the following:
  - All arguments are forwarded to the destination
  - The return value is forwarded to the caller
    - If the destination returns a reference to itself, it will be replaced with
      a reference to the caller's context (`this`).
  - If the call is expected to fail, either because the destination is not an
    object or because the requested method is not a function, a useful error
    will be immediately thrown (rather than the potentially cryptic one that
    would otherwise result, requiring analysis of the stack trace).

N.B. As of this commit, static proxies do not yet function properly.
2012-05-03 09:49:22 -04:00
Mike Gerwitz bc44bfd8e9 Set version to 0.2.0-dev 2012-03-05 22:55:14 -05:00
Mike Gerwitz fa9dbcbf2e [Fix #37] constructor property now properly set on instances 2012-01-19 23:21:04 -05:00
Mike Gerwitz 9dbd0d1fb3 Added constructor property to reserved members list 2012-01-17 23:36:01 -05:00
Mike Gerwitz 958521f673 Created version module to provide additional version information 2011-12-23 18:31:11 -05:00
Mike Gerwitz cdbcada4d2 Copyright year update 2011-12-23 00:09:11 -05:00
Mike Gerwitz 0739f983c7 Quoting keyword for consistency and to avoid potential minification issues 2011-12-22 23:40:39 -05:00
Mike Gerwitz 17047b53e9 Getters/setters will now trigger warnings if attempting to override without super getter/setter 2011-12-22 23:36:15 -05:00
Mike Gerwitz bcb0bcbe80 Added static validations for getters/setters 2011-12-22 23:36:15 -05:00
Mike Gerwitz db84c6fc6e Added virtual and override restrictions to getters/setters 2011-12-22 23:36:12 -05:00
Mike Gerwitz 9942ac9743 const getters/setters are unsupported (simply omit the setter) 2011-12-22 22:48:17 -05:00
Mike Gerwitz 4ada84e3b7 Abstract getters/setters are not yet supported
- Perhaps in future versions. The implementation details will not be ironed out before v0.1.0 and we can easily add it in the future without breaking BC. Getters/setters have not had too much attention thusfar in ease.js due to testing with systems that must work across many environments, including pre-ES5.
2011-12-22 22:46:02 -05:00
Mike Gerwitz 6295b83ec7 util.clone() primitive fix (broken in recent commit)
- null is considered to be type "object" by instanceof
2011-12-22 09:37:34 -05:00
Mike Gerwitz 021b67bbff Whoops - abstract member param names may now contain underscores 2011-12-22 09:10:51 -05:00
Mike Gerwitz a10cf82a12 Abstract member declaration parameter name restrictions now apply to all abstract member declarations, not just interfaces 2011-12-21 20:12:05 -05:00
Mike Gerwitz 50904390da Interface members may now only contain arg names that are valid var names
- This should apply to all abstract definitions. This will be resolved in the next commit. I am tired.
2011-12-20 23:56:46 -05:00
Mike Gerwitz e9cf630d0b AbstractClass.implement().extend() will now properly preserve abstract flag on resulting class
- This is a bug fix. The resulting class was not declared abstract, which is a problem if the resulting class chose not to provide a concrete implementation for each of the abstract members.
2011-12-20 20:06:38 -05:00
Mike Gerwitz 2136ebedd5 Now properly handling extending from objects and properly throwing errors for scalars 2011-12-15 22:58:33 -05:00
Mike Gerwitz e24784529e Resolved majority of Closure Compiler warnings (VERBOSE)
- Ignored warnings from tests for now
- VERBOSE flag removed from Makefile for now until I can figure out how to
  resolve certain warnings
2011-12-13 21:19:14 -05:00
Mike Gerwitz d1b1d2691a Fixed initial warnings provided by Closure Compiler
Getting ready for release means that we need to rest assured that everything is
operating as it should. Tests do an excellent job at aiding in this, but they
cannot cover everything. For example, a simple missing comma in a variable
declaration list could have terrible, global consequences.
2011-12-10 11:18:41 -05:00
Mike Gerwitz e0254f6441 Removed invalid @package tags
Not a valid tag in jsdoc
2011-12-06 20:19:31 -05:00
Mike Gerwitz e4cd1eabe5 Fixed issue with minified files in IE
Ah - you have to love those "ah-ha!" moments. The issue here is that both
uglify-js and closure compiler mangled the names in such a way that the var and
the function name had different values. In the case of closure compiler, the
function name was used to instantiate the constructor if the 'new' keyword was
omitted. This worked fine in all other tested browsers, but IE handles it
differently.
2011-12-06 18:20:43 -05:00
Mike Gerwitz 1a3b5f2893 Now using vm module in node instead of process.binding.Script (deprecated in newer versions of node) 2011-12-04 12:55:00 -05:00
Mike Gerwitz 27eea93d6f Now setting mocked console in warn module for tests
- Replacing console broken in newer versions of node/v8
- Replacing console.warn/log works fine, but is a poor choice for testing
2011-12-04 12:54:56 -05:00
Mike Gerwitz 446aa8d413 Fixed __self assignment for FF
This little experience was rather frustrating. Indeed, it would imply that
the static implementation (at least, accessing protected and private static
members) was always broken in FF. I should be a bit more diligent in my testing.
Or perhaps it broke in a more recent version of FF, which is more likely. The
problem seems to be that we used defineSecureProp() for an assignment to the
actual class, then later properly assigned it to class.___$$svis$$.
Of course, defineSecureProp() makes it read-only, so this failed, causing
an improper assignment for __self, breaking the implementation. As such,
this probably broke in newer versions of FF and worked properly in older versions.

More concerningly is that the implementations clearly differ between Chromium
and Firefox. It may be that Firefox checks the prototype chain, whereas Chromium
(v8, specifically) will simply write to that object, ignoring that the property
further down the prototype chain is read-only.
2011-12-04 00:32:16 -05:00
Mike Gerwitz e41495c0d1 Added private member name conflict validations 2011-12-03 00:38:41 -05:00
Mike Gerwitz ba28f0a753 Now implicitly adding abstract keyword for interface method declarations 2011-11-28 15:10:26 -05:00
Mike Gerwitz 87dd1b8961 [#29] Re-added interface name to interface errors since abstract requirement change 2011-11-19 22:17:59 -05:00
Mike Gerwitz a33df4dcbe [#29] Refactored interface extend() test against non-interface into ExtendTest 2011-11-19 22:05:18 -05:00
Mike Gerwitz 4fe20762c8 'abstract' keyword no longer required for interface method declarations
- A warning is not yet being thrown for redundancy if the abstract keyword is
  explicitly specified
2011-11-19 19:37:59 -05:00
Mike Gerwitz 4e49282515 Fixed bug causing invocation error when accessing undefined static members on a non-class base 2011-11-19 00:10:30 -05:00
Mike Gerwitz 80846e95f3 __proto__ => getPrototypeOf 2011-11-19 00:10:24 -05:00
Mike Gerwitz 94419742c0 Resolved IE8 test failures
- Additional checks for its buggy defineProperty(), etc implementation
2011-11-18 08:57:37 -05:00
Mike Gerwitz 8e079129f3 ClassBuilder.isInstanceOf() will no longer throw errors when given undefined for either argument
- Yes, this is just quickly adding a test to a pre-existing, terrible format.
  This will be refactored with the rest of the test case.
2011-11-15 22:23:00 -05:00
Mike Gerwitz c77d989b63 Prefixing warning output with 'Warning: ' 2011-11-05 12:10:20 -04:00
Mike Gerwitz bc589c035f Added warning handler to class facade
- This isn't yet tested; have to begin test case for facade
- Do note that the actual calling by MemberBuilderValidator is tested
2011-11-05 12:07:52 -04:00
Mike Gerwitz 8bcd55dbbb MemberBuilderValidator will now throw a warning if 'override' keyword is used without a super method 2011-11-05 11:58:12 -04:00
Mike Gerwitz 1fa92d44a1 [#25] Added Getter/Setter validator call tests for MemberBuilder 2011-11-05 09:40:58 -04:00
Mike Gerwitz e809c10dfe [#25] Added MemberBuilder/PropTest for validator call 2011-11-04 23:08:41 -04:00
Mike Gerwitz fdf630458a [#25] instanceof => typeof for functions; lib/ 2011-11-03 22:00:18 -04:00
Mike Gerwitz 4e2af2333d [#25] Now injecting MemberBuilderValidator into MemberBuilder 2011-11-02 23:28:23 -04:00
Mike Gerwitz 3912f2d369 [#25] Began refactoring test-class_builder-static into new test case system 2011-11-02 23:23:13 -04:00
Mike Gerwitz b063a91e40 [#25] Added visibility de-escalation and escalation tests to MemberBuilderValidator for getters/setters 2011-10-30 12:06:09 -04:00
Mike Gerwitz 91332353e9 [#25] Added attachInstanceOf TODO 2011-10-30 11:56:54 -04:00
Mike Gerwitz 3c676de55d [#25] Combined buildGetter() and buildSetter()
This helped to get rid of some unnecessary duplicate code and should also help
to improve performance slightly for getter/setter definitions.
2011-10-29 08:25:51 -04:00
Mike Gerwitz 02cd52cfb7 [#25] Began refactoring getter/setter building into a single method (util.propParse)
I'm unsure as to why I originally placed them in separate methods. propParse() will
always find a getter at the same time it finds a setter, and vice versa, should they
both have been defined on the object.
2011-10-29 08:08:02 -04:00
Mike Gerwitz 2ba8e2c8f0 [#25] Refactored common getter/setter code into common method within MemberBuilder 2011-10-29 07:47:22 -04:00