1
0
Fork 0
Commit Graph

450 Commits (71358eab5940564ea3009ae7df95e411277bc4f2)

Author SHA1 Message Date
Mike Gerwitz 28bf9e6421
Converted a number of test cases to new XUnit-style format 2012-05-03 21:47:43 -04:00
Mike Gerwitz 0d306b63c8
Moved setup method for XUnit style testing into tryTest() function to properly handle exceptions
- Most importantly in this case, skips
2012-05-03 21:47:36 -04:00
Mike Gerwitz e67c14e8c3
Added support for static proxy methods
When the static keyword is provided, the proxy will use the static accessor
method to look up the requested member.
2012-05-03 14:13:47 -04:00
Mike Gerwitz d84b86b21b
Added `proxy' keyword support
The concept of proxy methods will become an important, core concept in ease.js
that will provide strong benefits for creating decorators and proxies, removing
boilerplate code and providing useful metadata to the system. Consider the
following example:

  Class( 'Foo',
  {
      // ...

      'public performOperation': function( bar )
      {
          this._doSomethingWith( bar );
          return this;
      },
  } );

  Class( 'FooDecorator',
  {
      'private _foo': null,

      // ...

      'public performOperation': function( bar )
      {
          return this._foo.performOperation( bar );
      },
  } );

In the above example, `FooDecorator` is a decorator for `Foo`. Assume that the
`getValueOf()` method is undecorated and simply needs to be proxied to its
component --- an instance of `Foo`. (It is not uncommon that a decorator, proxy,
or related class will alter certain functionality while leaving much of it
unchanged.) In order to do so, we can use this generic, boilerplate code

  return this.obj.func.apply( this.obj, arguments );

which would need to be repeated again and again for *each method that needs to
be proxied*. We also have another problem --- `Foo.getValueOf()` returns
*itself*, which `FooDecorator` *also* returns.  This breaks encapsulation, so we
instead need to return ourself:

  'public performOperation': function( bar )
  {
      this._foo.performOperation( bar );
      return this;
  },

Our boilerplate code then becomes:

  var ret = this.obj.func.apply( this.obj, arguments );
  return ( ret === this.obj )
      ? this
      : ret;

Alternatively, we could use the `proxy' keyword:

  Class( 'FooDecorator2',
  {
      'private _foo': null,

      // ...

      'public proxy performOperation': '_foo',
  } );

`FooDecorator2.getValueOf()` and `FooDecorator.getValueOf()` both perform the
exact same task --- proxy the entire call to another object and return its
result, unless the result is the component, in which case the decorator itself
is returned.

Proxies, as of this commit, accomplish the following:
  - All arguments are forwarded to the destination
  - The return value is forwarded to the caller
    - If the destination returns a reference to itself, it will be replaced with
      a reference to the caller's context (`this`).
  - If the call is expected to fail, either because the destination is not an
    object or because the requested method is not a function, a useful error
    will be immediately thrown (rather than the potentially cryptic one that
    would otherwise result, requiring analysis of the stack trace).

N.B. As of this commit, static proxies do not yet function properly.
2012-05-03 09:49:22 -04:00
Mike Gerwitz 1b17900294 Resolved version test error caused by verset commit 2012-04-06 00:21:05 -04:00
Mike Gerwitz fa9dbcbf2e [Fix #37] constructor property now properly set on instances 2012-01-19 23:21:04 -05:00
Mike Gerwitz 9dbd0d1fb3 Added constructor property to reserved members list 2012-01-17 23:36:01 -05:00
Mike Gerwitz 958521f673 Created version module to provide additional version information 2011-12-23 18:31:11 -05:00
Mike Gerwitz cdbcada4d2 Copyright year update 2011-12-23 00:09:11 -05:00
Mike Gerwitz f264c1bf63 Added version number to exports 2011-12-23 00:03:08 -05:00
Mike Gerwitz 0dca143bdd Added {Abstract,Final}Class to index test 2011-12-23 00:03:08 -05:00
Mike Gerwitz 17047b53e9 Getters/setters will now trigger warnings if attempting to override without super getter/setter 2011-12-22 23:36:15 -05:00
Mike Gerwitz bcb0bcbe80 Added static validations for getters/setters 2011-12-22 23:36:15 -05:00
Mike Gerwitz db84c6fc6e Added virtual and override restrictions to getters/setters 2011-12-22 23:36:12 -05:00
Mike Gerwitz 9942ac9743 const getters/setters are unsupported (simply omit the setter) 2011-12-22 22:48:17 -05:00
Mike Gerwitz 4ada84e3b7 Abstract getters/setters are not yet supported
- Perhaps in future versions. The implementation details will not be ironed out before v0.1.0 and we can easily add it in the future without breaking BC. Getters/setters have not had too much attention thusfar in ease.js due to testing with systems that must work across many environments, including pre-ES5.
2011-12-22 22:46:02 -05:00
Mike Gerwitz 6295b83ec7 util.clone() primitive fix (broken in recent commit)
- null is considered to be type "object" by instanceof
2011-12-22 09:37:34 -05:00
Mike Gerwitz 021b67bbff Whoops - abstract member param names may now contain underscores 2011-12-22 09:10:51 -05:00
Mike Gerwitz a10cf82a12 Abstract member declaration parameter name restrictions now apply to all abstract member declarations, not just interfaces 2011-12-21 20:12:05 -05:00
Mike Gerwitz 50904390da Interface members may now only contain arg names that are valid var names
- This should apply to all abstract definitions. This will be resolved in the next commit. I am tired.
2011-12-20 23:56:46 -05:00
Mike Gerwitz e9cf630d0b AbstractClass.implement().extend() will now properly preserve abstract flag on resulting class
- This is a bug fix. The resulting class was not declared abstract, which is a problem if the resulting class chose not to provide a concrete implementation for each of the abstract members.
2011-12-20 20:06:38 -05:00
Mike Gerwitz 2136ebedd5 Now properly handling extending from objects and properly throwing errors for scalars 2011-12-15 22:58:33 -05:00
Mike Gerwitz d1b1d2691a Fixed initial warnings provided by Closure Compiler
Getting ready for release means that we need to rest assured that everything is
operating as it should. Tests do an excellent job at aiding in this, but they
cannot cover everything. For example, a simple missing comma in a variable
declaration list could have terrible, global consequences.
2011-12-10 11:18:41 -05:00
Mike Gerwitz e0254f6441 Removed invalid @package tags
Not a valid tag in jsdoc
2011-12-06 20:19:31 -05:00
Mike Gerwitz 58f2e3afc4 Made necessary changes to tests to prevent Closure Compiler from optimizing them away, causing test failures 2011-12-06 18:28:16 -05:00
Mike Gerwitz e385a9c8fb MemberBuilderValidator tests now properly wrap certain functions (they were working, but let's be safe) 2011-12-06 18:27:20 -05:00
Mike Gerwitz 74dd239de0 Corrected errors/warnings as indicated by Google Closure compiler 2011-12-04 19:26:53 -05:00
Mike Gerwitz e86ed63fd8 Fixed trailing comma issue in test
- Caused problems in IE6
- Comma stripping script did not catch it due to trailing comments
2011-12-04 13:06:28 -05:00
Mike Gerwitz 1a3b5f2893 Now using vm module in node instead of process.binding.Script (deprecated in newer versions of node) 2011-12-04 12:55:00 -05:00
Mike Gerwitz 27eea93d6f Now setting mocked console in warn module for tests
- Replacing console broken in newer versions of node/v8
- Replacing console.warn/log works fine, but is a poor choice for testing
2011-12-04 12:54:56 -05:00
Mike Gerwitz 0f4ce6acc1 Warning test workaround for FF
- Note that warnings do work properly in practice in FF
2011-12-04 11:38:24 -05:00
Mike Gerwitz f2e0bbc2f6 Outputting stack trace in browser tests if available 2011-12-03 15:51:53 -05:00
Mike Gerwitz e41495c0d1 Added private member name conflict validations 2011-12-03 00:38:41 -05:00
Mike Gerwitz ba28f0a753 Now implicitly adding abstract keyword for interface method declarations 2011-11-28 15:10:26 -05:00
Mike Gerwitz 2ef17cd297 IE uses empty string (rather than undefined) for unmatched regex groups 2011-11-20 20:37:59 -05:00
Mike Gerwitz a33df4dcbe [#29] Refactored interface extend() test against non-interface into ExtendTest 2011-11-19 22:05:18 -05:00
Mike Gerwitz 4fe20762c8 'abstract' keyword no longer required for interface method declarations
- A warning is not yet being thrown for redundancy if the abstract keyword is
  explicitly specified
2011-11-19 19:37:59 -05:00
Mike Gerwitz 91db43d21d [#29] Outputting newline and count every 60 tests 2011-11-19 14:15:31 -05:00
Mike Gerwitz c605113412 [#29] Refactored test-interface-extend into new test case format
- Preparing for minor changes
2011-11-19 14:09:59 -05:00
Mike Gerwitz 164b6a925b [#29] Added @each() support to test cases
- A little sloppy, but it gets the job done
2011-11-19 14:09:26 -05:00
Mike Gerwitz cef0c0146b [#29] Refactored test-interface.js into new test case format 2011-11-19 12:39:45 -05:00
Mike Gerwitz 4e49282515 Fixed bug causing invocation error when accessing undefined static members on a non-class base 2011-11-19 00:10:30 -05:00
Mike Gerwitz 94419742c0 Resolved IE8 test failures
- Additional checks for its buggy defineProperty(), etc implementation
2011-11-18 08:57:37 -05:00
Mike Gerwitz 8e079129f3 ClassBuilder.isInstanceOf() will no longer throw errors when given undefined for either argument
- Yes, this is just quickly adding a test to a pre-existing, terrible format.
  This will be refactored with the rest of the test case.
2011-11-15 22:23:00 -05:00
Mike Gerwitz c77d989b63 Prefixing warning output with 'Warning: ' 2011-11-05 12:10:20 -04:00
Mike Gerwitz 8bcd55dbbb MemberBuilderValidator will now throw a warning if 'override' keyword is used without a super method 2011-11-05 11:58:12 -04:00
Mike Gerwitz 1fa92d44a1 [#25] Added Getter/Setter validator call tests for MemberBuilder 2011-11-05 09:40:58 -04:00
Mike Gerwitz 1332da78a2 [#29] Added test skipping support to test case 2011-11-05 09:38:57 -04:00
Mike Gerwitz cb6c4af763 [#25] Refactored common MemberBuilder validator call assertion logic into a common module 2011-11-05 08:52:19 -04:00
Mike Gerwitz e809c10dfe [#25] Added MemberBuilder/PropTest for validator call 2011-11-04 23:08:41 -04:00
Mike Gerwitz fda002d252 [#25] Added tests to ensure proper data is passed to validateMethod() 2011-11-03 23:20:45 -04:00
Mike Gerwitz 6fd7ae8953 [#25] Tests with no assertions will be marked incomplete 2011-11-03 22:25:00 -04:00
Mike Gerwitz 705e228842 [#25] Added suite runner
- Getting closer to nice clean testing
2011-11-03 21:23:40 -04:00
Mike Gerwitz 4e2af2333d [#25] Now injecting MemberBuilderValidator into MemberBuilder 2011-11-02 23:28:23 -04:00
Mike Gerwitz 3912f2d369 [#25] Began refactoring test-class_builder-static into new test case system 2011-11-02 23:23:13 -04:00
Mike Gerwitz 79d0c4a62c [#25] Began moving test-class-implement over to new test case system 2011-11-02 22:32:45 -04:00
Mike Gerwitz f15fa03a3b [#25] Began moving test-class-visibility over to new test case style 2011-11-02 22:04:53 -04:00
Mike Gerwitz 48dbfea990 [#25] Began moving test-class_builder-visibility over to new test case format 2011-11-02 21:37:28 -04:00
Mike Gerwitz de78a472f0 [#25] MemberBuilder/MethodTest - removed unnecessary test 2011-11-02 19:12:15 -04:00
Mike Gerwitz 110d937838 [#25] Began converting test-class_builder-const to test case
- Not yet renaming, as the conversion is not yet complete
2011-11-02 19:11:12 -04:00
Mike Gerwitz a0ba2feb33 [#25] Removed transfered tests from test-class_builder-const 2011-10-30 14:22:17 -04:00
Mike Gerwitz b063a91e40 [#25] Added visibility de-escalation and escalation tests to MemberBuilderValidator for getters/setters 2011-10-30 12:06:09 -04:00
Mike Gerwitz 08cb663833 [#25] Refactored quickVisChangeTest to share code between each of the member test cases 2011-10-29 10:08:08 -04:00
Mike Gerwitz 3c676de55d [#25] Combined buildGetter() and buildSetter()
This helped to get rid of some unnecessary duplicate code and should also help
to improve performance slightly for getter/setter definitions.
2011-10-29 08:25:51 -04:00
Mike Gerwitz 02cd52cfb7 [#25] Began refactoring getter/setter building into a single method (util.propParse)
I'm unsure as to why I originally placed them in separate methods. propParse() will
always find a getter at the same time it finds a setter, and vice versa, should they
both have been defined on the object.
2011-10-29 08:08:02 -04:00
Mike Gerwitz 8433511f56 [#25] Added visibility [de-]escalation tests for properties 2011-10-28 20:22:53 -04:00
Mike Gerwitz 31a7980e37 [#25] Moved bulk of visibility escalation test into common file to be shared with other member tests 2011-10-28 20:22:14 -04:00
Mike Gerwitz 93021f3dbc [#25] Moved getter/setter validation tests into new test case
Much more elegant a test case now.
2011-10-28 00:22:50 -04:00
Mike Gerwitz ad0343fb9b [#25] Moved getter/setter validation logic into MemberBuilderValidator
- Tests have not yet been moved
2011-10-28 00:08:22 -04:00
Mike Gerwitz 05df0b485c [#25] Moved single access modifier getter/setter test to VisibilityTest 2011-10-27 20:46:30 -04:00
Mike Gerwitz f19a62e733 [#25] Moved public default getter/setter test to new location 2011-10-27 20:43:56 -04:00
Mike Gerwitz a959e99b06 [#25] Removed replaced vis tests from test-emmber_builder-gettersetter 2011-10-27 19:53:43 -04:00
Mike Gerwitz 5959956a27 [#25] this => _self replacements in MemberBuilder/VisibilityTest 2011-10-27 19:52:43 -04:00
Mike Gerwitz 11020a9d2a [#25] Minor typo fix in MemberBuilder/VisibilityTest 2011-10-27 19:51:28 -04:00
Mike Gerwitz 1ba160e51c [#25] Added getter/setter vis test to MemberBuilder/VisibilityTest 2011-10-27 19:50:13 -04:00
Mike Gerwitz ce7853965e [#25] Combined separate property and method vis test 2011-10-27 19:28:36 -04:00
Mike Gerwitz 6d1cc06c27 [#25] Finished refactoring MemberBuilder/MethodTest and removed inc-member_builder-common (no longer needed)
Finally feels like things are starting to come together.

It's rather interesting looking back. Each time I begin writing a piece of
software, I think to myself, "This is the best way to do it." Well, generally.
Perhaps the implementation could have been better, but I may not have had the
time. However, the general concept remains.

Each time I look back months later and find that I disagree with certain
decisions. I find certain implementations to be messy or poorly constructed. Or
perhaps I was just being lazy to begin with. Whatever the case, it is
comforting. It shows that one is continuing to learn and evolve.

Now, in the case of ease.js, we're working with a number of different factors in
regards to my perception of prior code quality. Primarily, I'm looking at a
basic implementation (in this case, I'm referring to test cases) that served as
a foundation that could be later evolved. I didn't have the time to devote to a
stronger solution. However, since the project has evolved so far past my
original expectations, a more sophisticated solution is needed in order to
simplify the overall design. That is what happened here.

Of course, we're also looking at a year's worth of additional, intimate
experience with a language.

Regardless of the reason, I love to see software evolve. Especially my own. It's
as if I'm watching my child grow. From that, I can get a great deal of
satisfaction.

One shouldn't expect perfection. But one should certainly aim for it.
2011-10-26 23:39:03 -04:00
Mike Gerwitz 88cff48599 [#25] Moved remaining tests in test-member_builder into MemberBuilder/VisibilityTest 2011-10-26 22:12:28 -04:00
Mike Gerwitz 2d494d577e [#25] Removed test-member_builder-prop; all tests have been moved 2011-10-26 00:03:26 -04:00
Mike Gerwitz e90699c805 [#25] Added test to MemberBuilder/Visibility test to ensure members will be declared public by default (if no access modifier is given) 2011-10-25 23:47:06 -04:00
Mike Gerwitz f4b8eb3589 [#25] Added test in MemberBuilder/VisibilityTest to ensure multiple access modifiers are not used 2011-10-25 23:30:57 -04:00
Mike Gerwitz 3482eb4cd7 [#25] Removed method hiding test (can restore when reimplementing) 2011-10-25 22:29:03 -04:00
Mike Gerwitz 625f62bbf1 [#25] Moved MemberBuilderValidator property tests into new test case 2011-10-23 01:14:13 -04:00
Mike Gerwitz 6fc3d05166 [#25] Moved quick keyword validation into shared MemberBuilderValidator test module 2011-10-23 01:11:09 -04:00
Mike Gerwitz a91cb01998 [#25] Moved MethodBuilder property validation into MemberBuilderValidator
- Tests have not yet been moved
2011-10-23 00:43:08 -04:00
Mike Gerwitz 5e46298e39 [#25] Moved MemberBuilderValidator's quickFailureTest into its own file to share with upcoming property tests 2011-10-23 00:27:25 -04:00
Mike Gerwitz 9b629b8b61 [#25] Removed tests from MemberBuilder/MethodTest that have been refactored into MemberBuilderValidator/MethodTest 2011-10-23 00:06:22 -04:00
Mike Gerwitz 9fe26e7582 [#25] Moved MemberBuilderValidator/MethodTest's helper functions into caseSetUp() 2011-10-22 16:49:51 -04:00
Mike Gerwitz 2da2247c86 [#25] Added successful test to MemberBuilderValidator's method tests to ensure successful functionality is also tested 2011-10-22 16:47:09 -04:00
Mike Gerwitz 8ebcc3f1b3 [#25] Removed duplicate code from MemberBuilderValidator method test 2011-10-22 16:37:58 -04:00
Mike Gerwitz a5e2a507f2 [#25] Throwing error instead of method hiding; will implement in future 2011-10-22 13:57:17 -04:00
Mike Gerwitz 6e7e031ff9 [#25] [#25] Re-added accidently removed portion of test 2011-10-22 11:06:03 -04:00
Mike Gerwitz f9b951ddb2 [#25] [#25] Began moving MemberBuilder validation rules into MemberBuilderValidator (moved method rules) 2011-10-22 01:00:45 -04:00
Mike Gerwitz e6830b741f [#25] Now using keywords to compare visibility levels in validations to eliminiate fallback inconsistencies
Ironic, considering the current refactoring (not yet committed) of MemberBuilder to split validation logic into MemberBuilderValidator was partially to be able to easily override the fallback logic. It's a useful refactoring nonetheless, but it could have waited.
2011-10-22 00:32:59 -04:00
Mike Gerwitz 4d2d95a99f [#25] Added test case error output for browser 2011-10-21 16:04:27 -04:00
Mike Gerwitz aeff796332 [#25] [#25] Added member builder tests for private and protected members 2011-10-21 16:04:24 -04:00
Mike Gerwitz ea972bdffc [#25] Added ability to manually increment assertion count for custom assertions 2011-10-21 12:10:53 -04:00
Mike Gerwitz 9ea60a18b0 [#25] Added assertion count to testcase output 2011-10-21 12:10:53 -04:00
Mike Gerwitz f7700f93e5 [#25] Refactored MemberBuilder/VisibilityTest basic tests into reusable functions for upcoming tests in other access levels 2011-10-21 12:10:49 -04:00
Mike Gerwitz bb9eb16fd3 [#25] Began adding MemberBuilder/VisibilityTest to test MemberBuilder directly
As mentioned in a prior commit blog-like entry, many of the tests evolved into more of an integration or system-level type of test. Let's get away from that.
2011-10-21 12:09:00 -04:00