[#25] Refactored MemberBuilder/VisibilityTest basic tests into reusable functions for upcoming tests in other access levels

test/MemberBuilder/VisibilityTest.js

@@ -22,7 +22,14 @@
  * @package test
  */
 
-function buildStubMethod( name, val, visibility )
+
+
+
+require( 'common' ).testCase(
+{
+    caseSetUp: function()
+    {
+        this.buildStubMethod = function( name, val, visibility )
         {
             var keywords = {};
 
@@ -38,10 +45,10 @@ function buildStubMethod( name, val, visibility )
                 1,
                 {}
             );
-}
+        };
 
 
-function buildStubProp( name, val, visibility )
+        this.buildStubProp = function( name, val, visibility )
         {
             var keywords = {};
 
@@ -49,21 +56,59 @@ function buildStubProp( name, val, visibility )
             keywords[ visibility ] = true;
 
             this.sut.buildProp( this.members, {}, name, val, keywords, {} );
-}
-
-
-require( 'common' ).testCase(
-{
-    caseSetUp: function()
-    {
-        this.buildStubMethod = function()
-        {
-            buildStubMethod.apply( this, arguments );
         };
 
-        this.buildStubProp = function()
+
+        this.assertOnlyIn = function( vis, name )
         {
-            buildStubProp.apply( this, arguments );
+            var found = false;
+
+            for ( level in this.members )
+            {
+                if ( typeof this.members[ level ][ name ] === 'undefined' )
+                {
+                    continue;
+                }
+
+                // we found it; ensure it's in the expected visibility level
+                found = true;
+                if ( level !== vis )
+                {
+                    this.fail( name + " should only be accessible in: " + vis );
+                }
+            }
+
+            found || this.fail(
+                "Did not find '" + name + "' in level: " + vis
+            );
+        };
+
+
+        this.basicVisPropTest = function( vis )
+        {
+            var name = 'pub',
+                val  = 'val';
+
+            this.buildStubProp( name, val, vis );
+            this.assertEqual( this.members[ vis ][ name ][ 0 ], val );
+
+            this.assertOnlyIn( vis, name, this.members );
+        };
+
+
+        this.basicVisMethodTest = function( vis )
+        {
+            var name = 'pub',
+                val  = 'val';
+
+            this.buildStubMethod( name, val, vis );
+
+            this.assertEqual(
+                this.members[ vis ][ name ](),
+                val
+            );
+
+            this.assertOnlyIn( vis, name, this.members );
         };
     },
 
@@ -83,26 +128,14 @@ require( 'common' ).testCase(
     },
 
 
-    'Public properties are accessible via the public interface': function()
+    'Public properties are accessible only via the public interface': function()
     {
-        var name = 'pub',
+        this.basicVisPropTest( 'public' );
-            val  = 'val';
-
-        this.buildStubProp( name, val, 'public' );
-        this.assertEqual( this.members[ 'public' ][ name ][ 0 ], val );
     },
 
 
-    'Public methods are accessible via the public interface': function()
+    'Public methods are accessible only via the public interface': function()
     {
-        var name = 'pub',
+        this.basicVisMethodTest( 'public' );
-            val  = 'val';
-
-        this.buildStubMethod( name, val, 'public' );
-
-        this.assertEqual(
-            this.members[ 'public' ][ name ](),
-            val
-        );
     },
 } );