From e809c10dfe3600cd7acd08100fedce4f8d6981fb Mon Sep 17 00:00:00 2001
From: Mike Gerwitz <mike@mikegerwitz.com>
Date: Fri, 4 Nov 2011 23:08:41 -0400
Subject: [PATCH] [#25] Added MemberBuilder/PropTest for validator call

---
 lib/MemberBuilder.js           |   4 +
 test/MemberBuilder/PropTest.js | 142 +++++++++++++++++++++++++++++++++
 2 files changed, 146 insertions(+)
 create mode 100644 test/MemberBuilder/PropTest.js

diff --git a/lib/MemberBuilder.js b/lib/MemberBuilder.js
index 341d02e..99c7cd0 100644
--- a/lib/MemberBuilder.js
+++ b/lib/MemberBuilder.js
@@ -7,6 +7,10 @@
  * Ultimately, however, such a decision is a micro-optimization and shouldn't
  * harm the design and maintainability of the software.
  *
+ * TODO: Implementation is inconsistent between various members. For example,
+ * methods use ___$$keywords$$, whereas properties use [ val, keywords ]. Decide
+ * on a common format.
+ *
  *  Copyright (C) 2010 Mike Gerwitz
  *
  *  This file is part of ease.js.
diff --git a/test/MemberBuilder/PropTest.js b/test/MemberBuilder/PropTest.js
new file mode 100644
index 0000000..1b5f651
--- /dev/null
+++ b/test/MemberBuilder/PropTest.js
@@ -0,0 +1,142 @@
+/**
+ * Tests MemberBuilder property builder
+ *
+ *  Copyright (C) 2010 Mike Gerwitz
+ *
+ *  This file is part of ease.js.
+ *
+ *  ease.js is free software: you can redistribute it and/or modify it under the
+ *  terms of the GNU Lesser General Public License as published by the Free
+ *  Software Foundation, either version 3 of the License, or (at your option)
+ *  any later version.
+ *
+ *  This program is distributed in the hope that it will be useful, but WITHOUT
+ *  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ *  FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public License
+ *  for more details.
+ *
+ *  You should have received a copy of the GNU Lesser General Public License
+ *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * @author  Mike Gerwitz
+ * @package test
+ */
+
+require( 'common' ).testCase(
+{
+    caseSetUp: function()
+    {
+        var _self = this;
+
+        this.testArgs = function( args, name, value, keywords )
+        {
+            var pub = _self.members[ 'public' ],
+
+                // prev data
+                pval_expect      = null,
+                pkeywords_expect = null,
+                pval_given       = null,
+                pkeywords_given  = null
+            ;
+
+            if ( pub[ name ] )
+            {
+                pval_expect      = pub[ name ][ 0 ];
+                pkeywords_expect = pub[ name ][ 1 ];
+
+                pval_given      = args[ 3 ].member[ 0 ];
+                pkeywords_given = args[ 4 ];
+            }
+
+            _self.assertEqual( name, args[ 0 ],
+                'Incorrect name passed to property validator'
+            );
+
+            _self.assertStrictEqual( value, args[ 1 ],
+                'Incorrect value passed to property validator'
+            );
+
+            _self.assertStrictEqual( keywords, args[ 2 ],
+                'Incorrect keywords passed to property validator'
+            );
+
+            _self.assertStrictEqual( pval_expect, pval_given,
+                'Previous data should contain prev value if overriding, ' +
+                'otherwise null'
+            );
+
+            _self.assertStrictEqual( pkeywords_expect, pkeywords_given,
+                'Previous keywords should contain prev keyword if ' +
+                'overriding, otherwise null'
+            );
+        };
+    },
+
+
+    setUp: function()
+    {
+        // stub factories used for testing
+        var stubFactory = this.require( 'MethodWrapperFactory' )(
+             function( func ) { return func; }
+        );
+
+        this.sut = this.require( 'MemberBuilder' )(
+            stubFactory, stubFactory,
+            this.mockValidate = this.getMock( 'MemberBuilderValidator' )
+        );
+
+        this.members = this.sut.initMembers();
+    },
+
+
+    /**
+     * The validator can only do its job if we're providing it with the correct
+     * information
+     */
+    'Passes proper data to validator when not overriding': function()
+    {
+        var _self  = this,
+            called = false,
+
+            name     = 'foo',
+            value    = 'bar',
+            keywords = {}
+        ;
+
+        this.mockValidate.validateProperty = function()
+        {
+            called = true;
+            _self.testArgs( arguments, name, value, keywords );
+        };
+
+        this.sut.buildProp( this.members, {}, name, value, keywords, {} );
+
+        this.assertEqual( true, called, 'validateProperty() was not called' );
+    },
+
+
+    'Passes proper data to validator when overriding': function()
+    {
+        var _self  = this,
+            called = false,
+
+            name     = 'foo',
+            value    = 'bar2',
+            keywords = {}
+        ;
+
+        // since we're overriding
+        this.members[ 'public' ][ name ] = [ 'prev', { 'public': true } ];
+
+        this.mockValidate.validateProperty = function()
+        {
+            called = true;
+            _self.testArgs( arguments, name, value, keywords );
+        };
+
+        this.sut.buildProp( this.members, {}, name, value, keywords, {} );
+
+        this.assertEqual( true, called, 'validateProperty() was not called' );
+    },
+} );
+