From cef45cd0977f5f3f2baa5a5d2da857aff63ee50b Mon Sep 17 00:00:00 2001 From: Mike Gerwitz Date: Wed, 6 Aug 2014 23:55:34 -0400 Subject: [PATCH] Corrected test broken by Node.js v0.10.27 Specifically, aae51ecf, which introduces deepEqual changes for comparing argument objects---specifically, this change: ```c if ((aIsArgs && !bIsArgs) || (!aIsArgs && bIsArgs)) return false; ``` Since I was comparing an array with an arguments object, deepEqual failed. While such an implementation may confuse users---since argument objects are generally treated like arrays---the distinction is important and I do agree with the change. --- test/MemberBuilder/MethodTest.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/MemberBuilder/MethodTest.js b/test/MemberBuilder/MethodTest.js index 06315fc..8491941 100644 --- a/test/MemberBuilder/MethodTest.js +++ b/test/MemberBuilder/MethodTest.js @@ -78,7 +78,9 @@ require( 'common' ).testCase( var stubProxyFactory = this.require( 'MethodWrapperFactory' )( function() { - _self.proxyFactoryCall = arguments; + _self.proxyFactoryCall = + Array.prototype.slice.call( arguments ); + return _self.proxyReturnValue; } );