From a1585a351e6d09407b97ff2cb7ec991a5950aeec Mon Sep 17 00:00:00 2001 From: Mike Gerwitz Date: Tue, 14 Jun 2011 23:00:37 -0400 Subject: [PATCH] Not running getter/setter override tests if unsupported by environment --- test/test-member_builder-method.js | 13 ++++++++++++- test/test-member_builder-prop.js | 13 ++++++++++++- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/test/test-member_builder-method.js b/test/test-member_builder-method.js index e092c69..7360f84 100644 --- a/test/test-member_builder-method.js +++ b/test/test-member_builder-method.js @@ -25,7 +25,8 @@ var common = require( './common' ), assert = require( 'assert' ), mb_common = require( __dirname + '/inc-member_builder-common' ), - builder = common.require( 'member_builder' ) + builder = common.require( 'member_builder' ), + util = common.require( 'util' ) ; mb_common.funcVal = 'foobar'; @@ -298,6 +299,11 @@ mb_common.assertCommon(); */ ( function testCannotOverrideGetters() { + if ( util.definePropertyFallback() ) + { + return; + } + mb_common.members[ 'public' ] = {}; Object.defineProperty( mb_common.members[ 'public' ], mb_common.name, { get: function() {}, @@ -334,6 +340,11 @@ mb_common.assertCommon(); */ ( function testCannotOverrideSetters() { + if ( util.definePropertyFallback() ) + { + return; + } + mb_common.members[ 'public' ] = {}; Object.defineProperty( mb_common.members[ 'public' ], mb_common.name, { set: function() {}, diff --git a/test/test-member_builder-prop.js b/test/test-member_builder-prop.js index 07b4048..f568868 100644 --- a/test/test-member_builder-prop.js +++ b/test/test-member_builder-prop.js @@ -25,7 +25,8 @@ var common = require( './common' ), assert = require( 'assert' ), mb_common = require( __dirname + '/inc-member_builder-common' ), - builder = common.require( 'member_builder' ) + builder = common.require( 'member_builder' ), + util = common.require( 'util' ) ; @@ -73,6 +74,11 @@ mb_common.assertCommon(); */ ( function testCannotOverrideGetters() { + if ( util.definePropertyFallback() ) + { + return; + } + mb_common.members[ 'public' ] = {}; Object.defineProperty( mb_common.members[ 'public' ], mb_common.name, { get: function() {}, @@ -109,6 +115,11 @@ mb_common.assertCommon(); */ ( function testCannotOverrideSetters() { + if ( util.definePropertyFallback() ) + { + return; + } + mb_common.members[ 'public' ] = {}; Object.defineProperty( mb_common.members[ 'public' ], mb_common.name, { set: function() {},