From 0ccab4f8d96bcef36b6abcd2ed4772c75892c4e9 Mon Sep 17 00:00:00 2001
From: Mike Gerwitz <mike@mikegerwitz.com>
Date: Sun, 6 Mar 2011 10:15:32 -0500
Subject: [PATCH 1/6] Corrected test combine process; was not including tests
 in ease-full.js

---
 test/test-member_builder-method.js |  2 +-
 test/test-member_builder-prop.js   |  2 +-
 tools/combine                      | 18 ++++++++++++------
 3 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/test/test-member_builder-method.js b/test/test-member_builder-method.js
index c5c711d..5ada826 100644
--- a/test/test-member_builder-method.js
+++ b/test/test-member_builder-method.js
@@ -24,7 +24,7 @@
 
 var common    = require( './common' ),
     assert    = require( 'assert' ),
-    mb_common = require( './inc-member_builder-common' )
+    mb_common = require( __dirname + '/inc-member_builder-common' )
 ;
 
 mb_common.value       = function() {};
diff --git a/test/test-member_builder-prop.js b/test/test-member_builder-prop.js
index 57b829f..1953a36 100644
--- a/test/test-member_builder-prop.js
+++ b/test/test-member_builder-prop.js
@@ -24,7 +24,7 @@
 
 var common    = require( './common' ),
     assert    = require( 'assert' ),
-    mb_common = require( './inc-member_builder-common' )
+    mb_common = require( __dirname + '/inc-member_builder-common' )
 ;
 
 mb_common.value       = { bar: 'baz' };
diff --git a/tools/combine b/tools/combine
index 49c756d..e6cd1b4 100755
--- a/tools/combine
+++ b/tools/combine
@@ -99,32 +99,38 @@ if [ "$INC_TEST" ]; then
     # note that not all tests are included
     TEST_CASES=$( find $PATH_TEST \
         \( -name 'test-*.js' \
-            -name 'inc-*.js' \
-            ! -name 'test-combine.js' \
-            ! -name 'test-index.js' \
+            -o -name 'inc-*.js' \
         \) \
         -exec basename {} \; \
+        | sort \
+        | grep -v 'test-\(combine\|index\).js' \
     )
 
     # include test combine template
     cat "$TPL_TEST_PATH" | grep -v '^#' | $RMTRAIL
 
     echo "/** TEST CASES **/"
-    echo "ns_exports.runTests = function ()"
+    echo "ns_exports.runTests = function()"
     echo "{"
 
     for testcase in $TEST_CASES; do
         filename="$PATH_TEST/$testcase"
 
+        # generate the module name by removing path and extension, then
+        # prefixing it with "test/"
+        module="${filename%.*}"
+        module="test/${module##*/}"
+
         # each module must be enclosed in a closure to emulate a module
         echo "/** TEST CASE: $testcase **/"
-        echo "( function()"
+        echo "( function( module, __dirname )"
         echo "{"
+        echo "    var exports = module.exports = {};"
 
         # add the module, removing trailing commas
         cat $filename | $RMTRAIL
 
-        echo "} )();"
+        echo "} )( module['$module'] = {}, 'test' );"
     done
 
     echo "};"

From 6a3789a730a4fd0d36e4372767e58e6fd56b7219 Mon Sep 17 00:00:00 2001
From: Mike Gerwitz <mike@mikegerwitz.com>
Date: Sun, 6 Mar 2011 10:20:38 -0500
Subject: [PATCH 2/6] Test failure message will now show up in browsers like
 IE6

---
 tools/browser-test.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/browser-test.html b/tools/browser-test.html
index bf5146f..938505d 100644
--- a/tools/browser-test.html
+++ b/tools/browser-test.html
@@ -24,7 +24,7 @@
       catch ( e )
       {
           body.style.color = 'red';
-          body.innerHTML = '<p>' + e.toString() + '</p>' +
+          body.innerHTML = '<p>' + e.message + '</p>' +
               '<p><em>ease.js is not guaranteed to run properly within this ' +
               'browser.</em></p>' +
               '<p>If building ease.js, remember to run <tt>`make combine` ' +

From 6b79999adb6ec37476607f26b985501e8d33c6fc Mon Sep 17 00:00:00 2001
From: Mike Gerwitz <mike@mikegerwitz.com>
Date: Sun, 6 Mar 2011 10:37:20 -0500
Subject: [PATCH 3/6] IE6 Error.prototype.toString() !== Error.message

---
 test/test-class-extend.js     | 2 +-
 test/test-class-name.js       | 8 ++++----
 test/test-interface-extend.js | 2 +-
 test/test-interface-name.js   | 8 ++++----
 4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/test/test-class-extend.js b/test/test-class-extend.js
index 6a78ac0..6def5f0 100644
--- a/test/test-class-extend.js
+++ b/test/test-class-extend.js
@@ -274,7 +274,7 @@ for ( var i = 0; i < class_count; i++ )
     catch ( e )
     {
         assert.notEqual(
-            e.toString().match( args.length + ' given' ),
+            e.message.match( args.length + ' given' ),
             null,
             "Class invocation should give argument count on error"
         );
diff --git a/test/test-class-name.js b/test/test-class-name.js
index 19fa1b9..c5f00d7 100644
--- a/test/test-class-name.js
+++ b/test/test-class-name.js
@@ -66,7 +66,7 @@ var common = require( './common' ),
     catch ( e )
     {
         assert.notEqual(
-            e.toString().match( name ),
+            e.message.match( name ),
             null,
             "Class definition argument count error string contains class name"
         );
@@ -96,7 +96,7 @@ var common = require( './common' ),
     }
     catch ( e )
     {
-        var errstr = e.toString();
+        var errstr = e.message;
 
         assert.notEqual(
             errstr.match( name ),
@@ -256,7 +256,7 @@ var common = require( './common' ),
     catch ( e )
     {
         assert.notEqual(
-            e.toString().match( name ),
+            e.message.match( name ),
             null,
             "Abstract class instantiation error should contain class name"
         );
@@ -276,7 +276,7 @@ var common = require( './common' ),
     catch ( e )
     {
         assert.notEqual(
-            e.toString().match( '(anonymous)' ),
+            e.message.match( '(anonymous)' ),
             null,
             "Abstract class instantiation error should recognize that class " +
                 "is anonymous if no name was given"
diff --git a/test/test-interface-extend.js b/test/test-interface-extend.js
index 2e542c7..f9197c5 100644
--- a/test/test-interface-extend.js
+++ b/test/test-interface-extend.js
@@ -192,7 +192,7 @@ for ( var i = 0; i < base_types.length; i++ )
     catch ( e )
     {
         assert.notEqual(
-            e.toString().match( args.length + ' given' ),
+            e.message.match( args.length + ' given' ),
             null,
             "Interface invocation should give argument count on error"
         );
diff --git a/test/test-interface-name.js b/test/test-interface-name.js
index dad582c..f41f874 100644
--- a/test/test-interface-name.js
+++ b/test/test-interface-name.js
@@ -67,7 +67,7 @@ var common     = require( './common' ),
     catch ( e )
     {
         assert.notEqual(
-            e.toString().match( name ),
+            e.message.match( name ),
             null,
             "Interface definition argument count error string contains " +
                 "interface name"
@@ -98,7 +98,7 @@ var common     = require( './common' ),
     }
     catch ( e )
     {
-        var errstr = e.toString();
+        var errstr = e.message;
 
         assert.notEqual(
             errstr.match( name ),
@@ -210,7 +210,7 @@ var common     = require( './common' ),
         {
             // ensure the error string contains the interface name
             assert.notEqual(
-                e.toString().match( name ),
+                e.message.match( name ),
                 null,
                 "Error contains interface name when available (" + i + ")"
             );
@@ -234,7 +234,7 @@ var common     = require( './common' ),
     catch ( e )
     {
         assert.notEqual(
-            e.toString().match( name ),
+            e.message.match( name ),
             null,
             "Interface name is included in instantiation error message"
         );

From 4eda438f141792690838ce2ed05d293a814be210 Mon Sep 17 00:00:00 2001
From: Mike Gerwitz <mike@mikegerwitz.com>
Date: Sun, 6 Mar 2011 10:55:13 -0500
Subject: [PATCH 4/6] Outputting current test for browser - Output is hidden on
 success, but useful on failure

---
 test/test-combine.js    | 7 ++++++-
 tools/browser-test.html | 2 +-
 tools/combine           | 4 ++++
 3 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/test/test-combine.js b/test/test-combine.js
index 0c384da..cdf4574 100644
--- a/test/test-combine.js
+++ b/test/test-combine.js
@@ -26,7 +26,12 @@ var common  = require( './common' ),
     assert  = require( 'assert' ),
     Class   = common.require( 'class' ),
     Script  = process.binding( 'evals' ).Script,
-    sandbox = {};
+
+    // sandbox in which combined script will be run
+    sandbox = {
+        // stub document.write() so we don't blow up
+        document: { write: function() {} },
+    };
 
 
 var files = [ 'ease.js', 'ease-full.js' ],
diff --git a/tools/browser-test.html b/tools/browser-test.html
index 938505d..86eb485 100644
--- a/tools/browser-test.html
+++ b/tools/browser-test.html
@@ -24,7 +24,7 @@
       catch ( e )
       {
           body.style.color = 'red';
-          body.innerHTML = '<p>' + e.message + '</p>' +
+          body.innerHTML += '<p>' + e.message + '</p>' +
               '<p><em>ease.js is not guaranteed to run properly within this ' +
               'browser.</em></p>' +
               '<p>If building ease.js, remember to run <tt>`make combine` ' +
diff --git a/tools/combine b/tools/combine
index e6cd1b4..50b01b7 100755
--- a/tools/combine
+++ b/tools/combine
@@ -127,6 +127,10 @@ if [ "$INC_TEST" ]; then
         echo "{"
         echo "    var exports = module.exports = {};"
 
+        # write out current test to make debugging easier in browsers with very
+        # little debugging support
+        echo "    document.write( '$module...<br />' )"
+
         # add the module, removing trailing commas
         cat $filename | $RMTRAIL
 

From a1c1ddff749ad137733eeaa785a075504ff4d29e Mon Sep 17 00:00:00 2001
From: Mike Gerwitz <mike@mikegerwitz.com>
Date: Sun, 6 Mar 2011 10:56:31 -0500
Subject: [PATCH 5/6] IE6 was blowing up on getter/setter test

---
 test/test-member_builder-gettersetter.js | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/test/test-member_builder-gettersetter.js b/test/test-member_builder-gettersetter.js
index 4fe908c..a6c037d 100644
--- a/test/test-member_builder-gettersetter.js
+++ b/test/test-member_builder-gettersetter.js
@@ -22,6 +22,12 @@
  * @package test
  */
 
+// no need to test getters/setters in browsers that do not support them
+if ( !Object.defineProperty )
+{
+    return;
+}
+
 var common    = require( './common' ),
     assert    = require( 'assert' ),
 

From 517b2be46432c570c7f906cc5410dd20e3da8ecd Mon Sep 17 00:00:00 2001
From: Mike Gerwitz <mike@mikegerwitz.com>
Date: Sun, 6 Mar 2011 12:38:31 -0500
Subject: [PATCH 6/6] Fix toString() override for IE - All tests once again
 pass on IE6

---
 lib/class.js              | 48 +++++++++++++++++++++++++++++++--------
 test/test-class-extend.js |  5 ++--
 2 files changed, 42 insertions(+), 11 deletions(-)

diff --git a/lib/class.js b/lib/class.js
index ec9e3cc..56e6bdd 100644
--- a/lib/class.js
+++ b/lib/class.js
@@ -34,6 +34,23 @@ var util           = require( './util' ),
  */
 var class_meta = {};
 
+/**
+ * IE contains a nasty enumeration "bug" (poor implementation) that makes
+ * toString unenumerable. This means that, if you do obj.toString = foo,
+ * toString will NOT show up in `for` or hasOwnProperty(). This is a problem.
+ *
+ * This test will determine if this poor implementation exists.
+ */
+var enum_bug = (
+        Object.prototype.propertyIsEnumerable.call(
+            { toString: function() {} },
+            'toString'
+        ) === false
+    )
+    ? true
+    : false
+;
+
 
 /**
  * This module may be invoked in order to provide a more natural looking class
@@ -419,6 +436,15 @@ var extend = ( function( extending )
             delete props.__name;
         }
 
+        // IE has problems with toString()
+        if ( enum_bug )
+        {
+            if ( props.toString !== Object.prototype.toString )
+            {
+                props.__toString = props.toString;
+            }
+        }
+
         util.propParse( props, {
             each: function( name, value, keywords )
             {
@@ -567,15 +593,19 @@ var extend = ( function( extending )
                     members[ 'public' ], 'toString'
                 ) ) )
                 {
-                    this.toString = ( cname )
-                        ? function()
-                        {
-                            return '[object #<' + cname + '>]';
-                        }
-                        : function()
-                        {
-                            return '[object #<anonymous>]';
-                        }
+                    // use __toString if available (see enum_bug), otherwise use
+                    // our own defaults
+                    this.toString = members[ 'public' ].__toString
+                        || ( ( cname )
+                            ? function()
+                            {
+                                return '[object #<' + cname + '>]';
+                            }
+                            : function()
+                            {
+                                return '[object #<anonymous>]';
+                            }
+                        )
                     ;
                 }
             };
diff --git a/test/test-class-extend.js b/test/test-class-extend.js
index 6def5f0..e5b0675 100644
--- a/test/test-class-extend.js
+++ b/test/test-class-extend.js
@@ -292,12 +292,13 @@ for ( var i = 0; i < class_count; i++ )
         result = ''
     ;
 
-    result = Class( 'Foo',
+    result = Class( 'FooToStr',
     {
         toString: function()
         {
             return str;
-        }
+        },
+        bla: function() {},
     })().toString();
 
     assert.equal(