Getters/setters are not supported within interface definitions
parent
c7b262b271
commit
188ad2f4eb
|
@ -77,6 +77,20 @@ var extend = ( function( extending )
|
||||||
);
|
);
|
||||||
},
|
},
|
||||||
|
|
||||||
|
getter: function()
|
||||||
|
{
|
||||||
|
throw TypeError(
|
||||||
|
"Getters are not permitted within Interface definitions"
|
||||||
|
);
|
||||||
|
},
|
||||||
|
|
||||||
|
setter: function()
|
||||||
|
{
|
||||||
|
throw TypeError(
|
||||||
|
"Setters are not permitted within Interface definitions"
|
||||||
|
);
|
||||||
|
},
|
||||||
|
|
||||||
method: function( name, value, is_abstract, keywords )
|
method: function( name, value, is_abstract, keywords )
|
||||||
{
|
{
|
||||||
if ( !is_abstract )
|
if ( !is_abstract )
|
||||||
|
|
|
@ -27,6 +27,8 @@ var common = require( './common' ),
|
||||||
Interface = common.require( 'interface' );
|
Interface = common.require( 'interface' );
|
||||||
|
|
||||||
|
|
||||||
|
( function testPropertiesNotPermittedWithinInterfaces()
|
||||||
|
{
|
||||||
assert.throws( function()
|
assert.throws( function()
|
||||||
{
|
{
|
||||||
Interface.extend(
|
Interface.extend(
|
||||||
|
@ -35,6 +37,29 @@ assert.throws( function()
|
||||||
prop: 'not permitted',
|
prop: 'not permitted',
|
||||||
});
|
});
|
||||||
}, TypeError, "Properties are not permitted within Interface definitions" );
|
}, TypeError, "Properties are not permitted within Interface definitions" );
|
||||||
|
} )();
|
||||||
|
|
||||||
|
|
||||||
|
( function testGettersAndSettersNotPermittedWithinInterfaces()
|
||||||
|
{
|
||||||
|
// don't perform this test if unsupported by environment
|
||||||
|
if ( Object.prototype.__defineGetter__ === undefined )
|
||||||
|
{
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
// so we don't break browsers that do not support getters/setters in object
|
||||||
|
// notation
|
||||||
|
var data = {};
|
||||||
|
data.__defineGetter__( 'foo', function() {} );
|
||||||
|
data.__defineSetter__( 'foo', function() {} );
|
||||||
|
|
||||||
|
assert.throws( function()
|
||||||
|
{
|
||||||
|
Interface.extend( data );
|
||||||
|
}, TypeError, "Getters/setters not permitted within Interfaces" );
|
||||||
|
} )();
|
||||||
|
|
||||||
|
|
||||||
assert.throws( function()
|
assert.throws( function()
|
||||||
{
|
{
|
||||||
|
|
Loading…
Reference in New Issue